-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid infinite loop caused by symbolic links #5813
Merged
pepicrft
merged 9 commits into
tuist:main
from
haifengkao:AvoidInifiteLoopCausedBySymbolicLink
Feb 23, 2024
Merged
avoid infinite loop caused by symbolic links #5813
pepicrft
merged 9 commits into
tuist:main
from
haifengkao:AvoidInifiteLoopCausedBySymbolicLink
Feb 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
reviewed
Jan 19, 2024
pepicrft
added
the
changelog:fixed
PR will be listed in the Fixed section of CHANGELOG
label
Jan 19, 2024
@all-contributors add @haifengkao for code |
I've put up a pull request to add @haifengkao! 🎉 |
Hi @haifengkao. Do you mind rebasing and fixing the linting issue? We can merge afterward. |
@pepicrft what linting issue? |
danieleformichelli
approved these changes
Feb 17, 2024
@haifengkao I brought the latest changes from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
Resolves #5685
How to test the changes locally 🧐
The link is dead
Contributor checklist ✅
mise run lint:fix
No, swift test doesn't work because
It won't affect users
Reviewer checklist ✅
changelog:added
,changelog:fixed
, orchangelog:changed
, and the title is usable as a changelog entry