Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid infinite loop caused by symbolic links #5813

Merged
merged 9 commits into from
Feb 23, 2024

Conversation

haifengkao
Copy link
Contributor

@haifengkao haifengkao commented Jan 19, 2024

Short description 📝

Resolves #5685

How to test the changes locally 🧐

Include a set of steps for the reviewer to test the changes locally (see the documentation for reference).

The link is dead

Contributor checklist ✅

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
    No, swift test doesn't work because
error: 'swiftgen': the package manifest at '/Volumes/D/tmp/tuist/.build/checkouts/SwiftGen/Package.swift' cannot be accessed (/Volumes/D/tmp/tuist/.build/checkouts/SwiftGen/Package.swift doesn't exist in file system)
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated
    It won't affect users

Reviewer checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@pepicrft pepicrft added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Jan 19, 2024
@pepicrft
Copy link
Contributor

@all-contributors add @haifengkao for code

Copy link
Contributor

@pepicrft

I've put up a pull request to add @haifengkao! 🎉

@pepicrft
Copy link
Contributor

Hi @haifengkao. Do you mind rebasing and fixing the linting issue? We can merge afterward.

@haifengkao
Copy link
Contributor Author

@pepicrft what linting issue?

@danieleformichelli danieleformichelli enabled auto-merge (squash) February 17, 2024 13:24
@pepicrft
Copy link
Contributor

@haifengkao I brought the latest changes from main. I'll merge once CI is green.

@pepicrft pepicrft merged commit 0440b6b into tuist:main Feb 23, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit command is stuck in infinite loop because of recursive symbolic links
3 participants