Embed external xcframeworks regardless of linking type #6217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
kwridan
approved these changes
Apr 22, 2024
| switch self { | ||
| case .macro: return false | ||
| case let .xcframework(xcframework): | ||
| return xcframework.linking == .dynamic | ||
| return xcframework.linking == .dynamic || xcframework.isExternal |
There was a problem hiding this comment.
From what I can see, we need to also restrict by xcframework type framework (.framework)
| XCFramework Type | Result | Note |
|---|---|---|
Static Library .a |
❌ | Embedding simply copies the .a to /Frameworks with all the symbols included |
Dynamic Library .dylib |
✅ | Embedding copies the .dylib to /Frameworks as expected |
Static Framework .framework |
✅ | Embedding copies the .framework to /Frameworks and strips symbols from framework binary |
Dynamic Framework .framework |
✅ | Embedding copies the .framework to /Frameworks as expected |
e.g. MyStaticLibrary.xcframework gets processed to a libMyStaticLibrary.a which shouldn't be embed.
It doesn't look like we capture the framework type information in the xcframework metadata - we can base it based on the library extension
Suggested change
| return xcframework.linking == .dynamic || xcframework.isExternal | |
| return xcframework.linking == .dynamic || (xcframework.isExternal && xcframework.infoPlist.libraries.first?.path.extension == "framework") |
or can uplift this to be a property on the metadata
Suggested change
| return xcframework.linking == .dynamic || xcframework.isExternal | |
| return xcframework.linking == .dynamic || (xcframework.isExternal && xcframework.type == .framework) |
There was a problem hiding this comment.
Gotcha 👍 I updated the PR with the first suggestion
There was a problem hiding this comment.
please see also the wrong linking for xcframeworks https://github.com/tuist/tuist/pull/6153/files
There was a problem hiding this comment.
maybe xcframework.linking is just wrong
fortmarek
added a commit
that referenced
this pull request
Apr 26, 2024
This reverts commit 3bebe42.
fortmarek
added a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6100
Short description 📝
This PR supersedes #6182 and #6183. I discussed this issue with @kwridan at SwiftHeroes and we both agreed that the best approach for the missing privacy report is to follow what Apple is doing by embedding xcframeworks. That being said, to minimise the impact this change might have (especially regarding resources), we will be only embedding xcframeworks if they are external.
How to test the changes locally 🧐
Generating privacy report for
app_with_spm_dependenciesshould includeGoogleMobileAdsContributor checklist ✅
mise run lint:fixReviewer checklist ✅
changelog:added,changelog:fixed, orchangelog:changed, and the title is usable as a changelog entry