Revert "Embed external xcframeworks regardless of linking type (#6217)" #6237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3bebe42.
Short description π
Some embedded xcframeworks lead to issues when uploading the app to App Store Connect:
We followed Xcode 15.3 behavior but looks like the behavior is buggy: https://forums.developer.apple.com/forums/thread/705297
This means the privacy report won't be generated for these xcframeworks but we haven't seen Apple rejecting apps over that, yet.
How to test the changes locally π§
Generate a project with a binary SPM dependency β it shouldn't be embedded
Contributor checklist β
mise run lint:fix
Reviewer checklist β
changelog:added
,changelog:fixed
, orchangelog:changed
, and the title is usable as a changelog entry