Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Embed external xcframeworks regardless of linking type (#6217)" #6237

Merged
merged 1 commit into from Apr 26, 2024

Conversation

fortmarek
Copy link
Member

This reverts commit 3bebe42.

Short description πŸ“

Some embedded xcframeworks lead to issues when uploading the app to App Store Connect:

ERROR ITMS-90208: Invalid Bundle. The bundle MyApp.app/Frameworks/BrazeKit.framework does not support the minimum OS Version specified in the Info.plist.
Return status of iTunes Transporter was 1: Asset validation failed - Invalid Bundle. The bundle MyApp.app/Frameworks/BrazeKit.framework does not support the minimum OS Version specified in the Info.plist. - STATE_ERROR.VALIDATION_ERROR.90208

We followed Xcode 15.3 behavior but looks like the behavior is buggy: https://forums.developer.apple.com/forums/thread/705297

This means the privacy report won't be generated for these xcframeworks but we haven't seen Apple rejecting apps over that, yet.

How to test the changes locally 🧐

Generate a project with a binary SPM dependency – it shouldn't be embedded

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@fortmarek fortmarek added the changelog:fixed PR will be listed in the Fixed section of CHANGELOG label Apr 26, 2024
@fortmarek fortmarek requested a review from kwridan April 26, 2024 14:41
@fortmarek fortmarek merged commit e04d3ce into main Apr 26, 2024
8 checks passed
@fortmarek fortmarek deleted the revert/embed-xcframeworks branch April 26, 2024 14:55
@balavor
Copy link

balavor commented Apr 29, 2024

While using mergeable frameworks, symbols from embedded frameworks that are merged as static frameworks are stripped. However, regular static frameworks will be copied entirely.

It automatically leads to an increased binary size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:fixed PR will be listed in the Fixed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants