Do not generate resource accessors for internal targets with resources and Objective-C source files #6388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description π
As reported by Etsy, their
GCC_PREFIX_HEADER
is unexpectedly overridden by tuist. This regression was introduced here. At the time, we thought overridingGCC_PREFIX_HEADER
should be fine but this assumption turned out not to be true.For the time being, we will again no longer generate objc resource accessors. We can start generating them again once we figure out how not to use
GCC_PREFIX_HEADER
as described here.How to test the changes locally π§
An internal target with objc files and resources shouldn't have tuist-generated resource accessors.
Contributor checklist β
mise run lint:fix
Reviewer checklist β
changelog:added
,changelog:fixed
, orchangelog:changed
, and the title is usable as a changelog entry