Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate resource accessors for internal targets with resources and Objective-C source files #6388

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

fortmarek
Copy link
Member

Short description πŸ“

As reported by Etsy, their GCC_PREFIX_HEADER is unexpectedly overridden by tuist. This regression was introduced here. At the time, we thought overriding GCC_PREFIX_HEADER should be fine but this assumption turned out not to be true.

For the time being, we will again no longer generate objc resource accessors. We can start generating them again once we figure out how not to use GCC_PREFIX_HEADER as described here.

How to test the changes locally 🧐

An internal target with objc files and resources shouldn't have tuist-generated resource accessors.

Contributor checklist βœ…

  • The code has been linted using run mise run lint:fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

@fortmarek fortmarek added the changelog:changed PR will be listed in the Changed section of CHANGELOG label Jun 10, 2024
@fortmarek fortmarek merged commit aeeb19b into main Jun 10, 2024
8 checks passed
@fortmarek fortmarek deleted the fix/pch_override branch June 10, 2024 16:00
@darrarski
Copy link
Collaborator

This is great! I experienced the problem yesterday, and I was about to open an issue. Thanks for your valuable contribution! β™₯️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed PR will be listed in the Changed section of CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants