Cache the helpers module #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
kwridan and
ollieatkinson
and removed request for
a team
kwridan
approved these changes
Nov 18, 2019
| let dylibName = "libProjectDescriptionHelpers.dylib" | ||
|
|
||
| if FileHandler.shared.exists(helpersModuleCachePath) { | ||
| return helpersModuleCachePath.appending(component: dylibName) |
There was a problem hiding this comment.
As a further optimization, you could cache the known built dylib paths in an in memory cache (saves calculating hashes repeatedly for every manifest)
| let helpersPath = path.appending(RelativePath("Tuist/ProjectDescriptionHelpers")) | ||
| try FileHandler.shared.createFolder(helpersPath) | ||
| try FileHandler.shared.write("import Foundation; class Test {}", path: helpersPath.appending(component: "Helper.swift"), atomically: true) | ||
| let projectDescriptionPath = try resourceLocator.projectDescription() | ||
|
|
||
| // When | ||
| _ = try subject.build(at: path, projectDescriptionPath: projectDescriptionPath) |
There was a problem hiding this comment.
Is the purpose of adding two calls here to test out caching?
If so, perhaps we could do that in a separate test that tests for it a bit more explicitly?
e.g.
// When
let paths = try (0..<3).map { _ in try subject.build(at: path, projectDescriptionPath: projectDescriptionPath) }
// Then
// check all the paths are equal There was a problem hiding this comment.
That's a good idea. I changed the current test to follow your approach instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #668
Short description 馃摑
This PR adds support for caching the project description helpers modules across runs. If any of the files under the helpers directory changes, the logic deletes the old version of the framework automatically.
Solution 馃摝
Extend the
ProjectDescriptionHelpersBuilderlogic to cache the frameworks in a system directory.