Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document project description helpers #692

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Document project description helpers #692

merged 1 commit into from
Nov 19, 2019

Conversation

pepicrft
Copy link
Contributor

Resolves #668

Short description 📝

This PR adds documentation for the project description helpers.

cc @andreacipriani / @RomainBoulay

image

@pepicrft pepicrft requested a review from a team November 18, 2019 17:08
@pepicrft pepicrft self-assigned this Nov 18, 2019
@ghost ghost requested review from kwridan and marciniwanicki and removed request for a team November 18, 2019 17:08
@pepicrft pepicrft mentioned this pull request Nov 18, 2019
11 tasks
import Message from '../components/message'
import { List } from 'semantic-ui-react'

# Project description helpers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pepibumur Have you considered changing the [...]Description naming to something like [...]Toolbox. That's my own POV but description sends me documentation inputs rather than something that I understand is more a shared space for Project.swift files. I feel that suffixes like Core, Toolkit, Factory or Toolbox would bring a better definition. But that said I might be totally wrong! I'm still definitely a Tuist beginner ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw... on this topic, I might also suggest renaming Project.swift files to Tuist.swift, TuistFile or TuistProject.swift... I feel that Project.swift drops the brand aspect, which is IMO important, it would also tell a complete beginner that this file is related to Tuist, without needing to ask around

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are good points. Answering to the first point. We made that for consistency reasons with the Swift Package Manager and other libraries. The Swift Package Manager calls the manifests target PackageDescription. The helpers idea was inspired by Rails that calls helpers to functions that extract views’ functionality.

Regarding the second point, it was a conscious a bit influenced by the Swift Package Manager. All the files and folders that are the input of Tuist have generic names so that the name of Tuist doesn’t ens up all over the place. Following your suggestion would be much better from the branding point of vie, but something that I wouldn’t reconsider at the moment. What about opening an issue to revisit before the next major release?

@RomainBoulay
Copy link
Contributor

RomainBoulay commented Nov 18, 2019 via email

@pepicrft pepicrft merged commit 371a7f0 into master Nov 19, 2019
@pepicrft pepicrft deleted the document-helpers branch November 19, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project description helpers
2 participants