Delete manifest generation #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
kwridan and
ollieatkinson
and removed request for
a team
pepicrft
force-pushed
the
delete-generate-manifest
branch
from
bbfae22
to
64a9e9f
Compare
kwridan
reviewed
Nov 26, 2019
| @@ -4,6 +4,9 @@ Please, check out guidelines: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| ## Next | |||
|
|
|||
| ### Removed | |||
There was a problem hiding this comment.
Is it worth marking this as "breaking" ?
For anyone that did a tuist init in prior versions and upgrades to this version, tuist generate may fail as it won't recognise .generateManifest option
There was a problem hiding this comment.
Is it worth marking this as "breaking" ?
Good point. We should definitively mark this one as breaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #668
Short description 📝
With the introduction of the edit command generating the manifests target in the generated project is no longer necessary. For that reason, I'm removing that logic in this PR.
Implementation 👩💻👨💻
.generateManifestgeneration option.