Add knownRegions to generated projects #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Based on localizable resources we can infer the knownRegions of the project - While adding localizable resources file elements we can keep track of the languages encountered Test Plan: - Run `tuist generate` within `fixtures/ios_app_with_framework_and_resources` - Verify the generated project MainApp has both "English" and "French" in the list of localizations in the project's info tab
2 tasks
lakpa
reviewed
Dec 16, 2019
| configurationList: XCConfigurationList, | ||
| groups: ProjectGroups, | ||
| pbxproj: PBXProj) throws -> PBXProject { | ||
| let defaultRegions = ["en"] |
There was a problem hiding this comment.
is en a default region always, is there a possibility you can have other region as default?
There was a problem hiding this comment.
At the moment its set the match the default region generated by Tuist:
https://github.com/tuist/XcodeProj/blob/master/Sources/XcodeProj/Project/Xcode.swift#L47
Could be a separate enhancement to support specifying the default development regions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #659
Short description 📝
Generated projects were missing an exhaustive list of known regions. This causes Xcode to immediately modify generated projects on launch to fix this.
Solution 📦
The list of known regions can be included in the generated projects. Based on localizable resources we can infer the known regions of the project.
This can be achieved by keeping track of the localizations encountered when adding while adding localizable resource file elements.
Implementation 👩💻👨💻
ProjectFileElementsto keep track of localizationsProjectGeneratorto set the appropriateknownRegionsbased on the localisations tracked by theProjectFileElementsTest Plan 🛠
tuist generatewithinfixtures/ios_app_with_framework_and_resources