Add knownRegions to generated projects

CHANGELOG.md

@@ -44,6 +44,7 @@ Please, check out guidelines: https://keepachangelog.com/en/1.0.0/
 - Remove duplicate HEADER_SEARCH_PATHS https://github.com/tuist/tuist/pull/787 by @kwridan
 - Fix unstable scheme generation https://github.com/tuist/tuist/pull/790 by @marciniwanicki
 - Add defaultConfigurationName to generated projects https://github.com/tuist/tuist/pull/793 by @kwridan
+- Add knownRegions to generated projects https://github.com/tuist/tuist/pull/792 by @kwridan
 
 ## 0.19.0
 

Sources/TuistGenerator/Generator/ProjectFileElements.swift

@@ -32,8 +32,12 @@ class ProjectFileElements {
     var elements: [AbsolutePath: PBXFileElement] = [:]
     var products: [String: PBXFileReference] = [:]
     var sdks: [AbsolutePath: PBXFileReference] = [:]
-    let playgrounds: Playgrounding
-    let filesSortener: ProjectFilesSortening
+    var knownRegions: Set<String> = Set([])
+
+    // MARK: - Private
+
+    private let playgrounds: Playgrounding
+    private let filesSortener: ProjectFilesSortening
 
     // MARK: - Init
 
@@ -372,13 +376,14 @@ class ProjectFileElements {
                                          pbxproj: PBXProj) {
         let localizedFilePath = localizedFile.relative(to: localizedContainer.parentDirectory)
         let lastKnownFileType = localizedFile.extension.flatMap { Xcode.filetype(extension: $0) }
-        let name = localizedContainer.basename.split(separator: ".").first
+        let language = localizedContainer.basenameWithoutExt
         let localizedFileReference = PBXFileReference(sourceTree: .group,
-                                                      name: name.map { String($0) },
+                                                      name: language,
                                                       lastKnownFileType: lastKnownFileType,
                                                       path: localizedFilePath.pathString)
         pbxproj.add(object: localizedFileReference)
         variantGroup.children.append(localizedFileReference)
+        knownRegions.insert(language)
     }
 
     func addVersionGroupElement(from: AbsolutePath,

Sources/TuistGenerator/Generator/ProjectGenerator.swift

@@ -105,6 +105,7 @@ final class ProjectGenerator: ProjectGenerating {
                                               sourceRootPath: sourceRootPath)
         let configurationList = try configGenerator.generateProjectConfig(project: project, pbxproj: pbxproj, fileElements: fileElements)
         let pbxProject = try generatePbxproject(project: project,
+                                                projectFileElements: fileElements,
                                                 configurationList: configurationList,
                                                 groups: groups,
                                                 pbxproj: pbxproj)
@@ -134,16 +135,19 @@ final class ProjectGenerator: ProjectGenerating {
     }
 
     private func generatePbxproject(project: Project,
+                                    projectFileElements: ProjectFileElements,
                                     configurationList: XCConfigurationList,
                                     groups: ProjectGroups,
                                     pbxproj: PBXProj) throws -> PBXProject {
+        let defaultRegions = ["en"]
+        let knownRegions = Set(defaultRegions + projectFileElements.knownRegions).sorted()
         let pbxProject = PBXProject(name: project.name,
                                     buildConfigurationList: configurationList,
                                     compatibilityVersion: Xcode.Default.compatibilityVersion,
                                     mainGroup: groups.main,
                                     developmentRegion: Xcode.Default.developmentRegion,
                                     hasScannedForEncodings: 0,
-                                    knownRegions: ["en"],
+                                    knownRegions: knownRegions,
                                     productsGroup: groups.products,
                                     projectDirPath: "",
                                     projects: [],

Tests/TuistGeneratorTests/Generator/ProjectFileElementsTests.swift

@@ -222,6 +222,41 @@ final class ProjectFileElementsTests: TuistUnitTestCase {
         ])
     }
 
+    func test_addElement_lproj_knownRegions() throws {
+        // Given
+        let temporaryPath = try self.temporaryPath()
+        let resouces = try createFiles([
+            "resources/en.lproj/App.strings",
+            "resources/en.lproj/Extension.strings",
+            "resources/fr.lproj/App.strings",
+            "resources/fr.lproj/Extension.strings",
+            "resources/Base.lproj/App.strings",
+            "resources/Base.lproj/Extension.strings",
+        ])
+
+        let elements = resouces.map {
+            GroupFileElement(path: $0,
+                             group: .group(name: "Project"),
+                             isReference: true)
+        }
+
+        // When
+        try elements.forEach {
+            try subject.generate(fileElement: $0,
+                                 groups: groups,
+                                 pbxproj: pbxproj,
+                                 sourceRootPath: temporaryPath)
+        }
+
+        // Then
+
+        XCTAssertEqual(subject.knownRegions, Set([
+            "en",
+            "fr",
+            "Base",
+        ]))
+    }
+
     func test_targetFiles() throws {
         // Given
         let settings = Settings.test(

Tests/TuistGeneratorTests/Generator/ProjectGeneratorTests.swift

@@ -237,4 +237,35 @@ final class ProjectGeneratorTests: TuistUnitTestCase {
         XCTAssertEqual(got.pbxproj.objectVersion, 50)
         XCTAssertEqual(got.pbxproj.archiveVersion, Xcode.LastKnown.archiveVersion)
     }
+
+    func test_knownRegions() throws {
+        // Given
+        let path = try temporaryPath()
+        let graph = Graph.test(entryPath: path)
+        let resources = [
+            "resources/en.lproj/App.strings",
+            "resources/en.lproj/Extension.strings",
+            "resources/fr.lproj/App.strings",
+            "resources/fr.lproj/Extension.strings",
+            "resources/Base.lproj/App.strings",
+            "resources/Base.lproj/Extension.strings",
+        ]
+        let project = Project.test(path: path,
+                                   targets: [
+                                       .test(resources: resources.map {
+                                           .file(path: path.appending(RelativePath($0)))
+                                       }),
+                                   ])
+
+        // When
+        let got = try subject.generate(project: project, graph: graph)
+
+        // Then
+        let pbxProject = try XCTUnwrap(try got.pbxproj.rootProject())
+        XCTAssertEqual(pbxProject.knownRegions, [
+            "Base",
+            "en",
+            "fr",
+        ])
+    }
 }