-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TargetAction script fix #997
Conversation
Codecov Report
@@ Coverage Diff @@
## master #997 +/- ##
==========================================
+ Coverage 78.8% 78.96% +0.16%
==========================================
Files 199 200 +1
Lines 10821 10920 +99
==========================================
+ Hits 8527 8623 +96
- Misses 2294 2297 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for tackling this @fortmarek. Your changes look good to me. |
The acceptance tests are failing due the script file permissions - I believe it needs to be executable. |
The |
Resolves #994
Short description 📝
As @kwridan has rightly pointed out, in order for
TargetAction
that invokes a script to work, you have to use./name_of_your_script.sh
, rather thanname_of_your_script.sh
in the build phase - but you can not do that forTargetAction
withpath
(as it will convert it to without./
prefix)Solution 📦
Adding
${PROJECT_DIR}
to path of the script resolves the issue - both versions should now work.Implementation 👩💻👨💻
${PROJECT_DIR}
prefix