Deletion from vector while looping over the vector

[AbhishekBagchi]

In CommandAnalysis::getCommands, we're looping over the command list, and possibly deleting the elements as we go over the list and moving those elements to next_window_cmd_list.
So if the first element is a precharge that was inserted from the previous window in
if (!next_window_cmd_list.empty()) { list.insert(list.begin(), next_window_cmd_list.begin(), next_window_cmd_list.end()); next_window_cmd_list.clear(); }
In this case, element 0 gets deleted, so element 1 is at index 0 now, which gets skipped over. If that element is an ACT or RDA or WRA, this leads to an error.