Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Retail Bug Report] Macro with modifier on ActionBar no longer works after upgrading from 13.11 to 13.13 #706

Closed
5 of 6 tasks
dgimb89 opened this issue Dec 17, 2022 · 11 comments

Comments

@dgimb89
Copy link
Contributor

dgimb89 commented Dec 17, 2022

What is the issue you are having?

Greetings,

I upgraded from 13.11 to 13.13 this morning and multiple of my macros that use modifier conditionals do no longer work.

Example: Macro that is placed on ActionBar with Keybind C

#showtooltip
/cast [modifier:shift] Berserking
/cast [modifier:shift] Ancestral Guidance
/cast [nomod:shift,known:114052] Ascendance
/cast [nomod:shift,known:197995] Wellspring

As there was a recent change about ActionBarButton activation, I figured that could be related to the recent change. Downgrading back to 13.11 fixes it.

What is the expected behavior?

When I hold down shift and press C, it should use Berserking as well as Ancestral Guidance,

What actually happened?

No spell is being casted. Simplifying the macro does not help, any modifier:shift conditional will prevent the cast.

Suggested Solution/Workaround

No response

Errors

No response

ElvUI Changelog & Troubleshooting

  • I have confirmed that I have read the Changelog.
  • I have verfied ElvUI is up to date by checking /estatus.
  • I have verfied my issue doesn't exist in the ElvUI Issue Tracker.
  • I have not read step six and I am just clicking all boxes.
  • I have verfied my issue doesn't exist in the default UI.
  • I have disabled all addons except the three called 'ElvUI', 'ElvUI Libraries', and 'ElvUI Options' by using /edebug on? This is important in order to rule out that any of your other addons are causing the issue. If you manage to pinpoint a conflict between ElvUI and another addon, make sure you include that information.
@kodewdle
Copy link
Member

kodewdle commented Dec 17, 2022

try on 13.14 please and let us know thank you - to be clear, i didn't add anything to fix this just want a recheck on 13.14

@DarkforceNL
Copy link

I have the same Problem, 13.13 broke the shift macro button for me
also 13.14 didnt work

@dgimb89
Copy link
Contributor Author

dgimb89 commented Dec 18, 2022

@kodewdle Still present in 13.14. Same issue with /edebug on. I did another test by installing 13.12 and that's when the issue was introduced.

As a workaround for now, I downgraded to 13.11. If you need some more details how to reproduce this or need me to test any bugfixes, I'm happy to help.

@DarkforceNL
Copy link

cant seem to downgrade cus i cant find older versions from elvui, but what i did found out is that when you enable lockcast bars and then change the drag button from default (shift) to (none) it seems to work again for me
lmk what you find out

@dgimb89
Copy link
Contributor Author

dgimb89 commented Dec 18, 2022

@DarkforceNL That worked for me too. Disabling "Lock ActionBars" did not do the trick, but enabling and setting it to "None" did.

@DarkforceNL
Copy link

@DarkforceNL That worked for me too. Disabling "Lock ActionBars" did not do the trick, but enabling and setting it to "None" did.

Thats why i sad Enable :P and nice that it worked :)

@Squimbert
Copy link

Same issue. When using a macro like:

#showtooltip
/use [mod:shift]Mighty Caravan Brutosaur;Grand Expedition Yak

and having the ElvUI Pick up Action Key set to shift (the same modifier in the macro), the macro no longer works.

When i change the picup action key to something that is not in my macro (for example alt in the above case), the issue resolves. But i would still ideally like my pickup key to be shift as well as my modifier in my macro to be shift as well.

@wing5wong
Copy link
Contributor

wing5wong commented Dec 21, 2022

following this as experiencing the same.
i use many shift/ctrl mod macros so this is quite high impact. (not sure what the initial fixes that introduced this fixed, maybe more important)
obviously changing the actionbar drag key (to alt in my case) can limit the effect of this but still, its an awkward workaround at best so ideally there is some other solution that can come out of this at some stage. (i appreciate this issue appears to be related to blizz issues so may be some time)

@georgi-chinov
Copy link

Same behaviour with selfcast key dropdown (disables the alt mod in macros):
image

@Altonymous
Copy link

Any updates on this? I've found I can get them to work if I go into Options > Action Bars > Lock ActionBars and change it to None. I have to do this each time I start the game as ElvUI seems to reset it back to Shift. When I remove ElvUI my changes remain, that's how I'm determining that it's ElvUI resetting it.

@Azilroka
Copy link
Member

Azilroka commented Feb 6, 2023

Any updates on this? I've found I can get them to work if I go into Options > Action Bars > Lock ActionBars and change it to None. I have to do this each time I start the game as ElvUI seems to reset it back to Shift. When I remove ElvUI my changes remain, that's how I'm determining that it's ElvUI resetting it.

So you are saying it does it every time you login?

Did you do the troubleshooting steps? /edebug on

Because when I have just ElvUI, ElvUI Options and ElvUI Libraries.. It doesn't automatically swap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants