Merge pull request #941 from CurtisEppel/fix-acl-type-discrepancy

Fix acl type declarations to match implementation
tulios · Nov 4, 2020 · 668b85e · 668b85e
2 parents 7154895 + 9b93ada
commit 668b85e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/types/index.d.ts b/types/index.d.ts
@@ -370,7 +370,7 @@ export interface AclResource {
 export type AclEntry = Acl & AclResource
 
 export type DescribeAclResource = AclResource & {
-  acls: Acl[]
+  acl: Acl[]
 }
 
 export interface DescribeAclResponse {
@@ -454,7 +454,7 @@ export type Admin = {
   describeGroups(groupIds: string[]): Promise<GroupDescriptions>
   describeAcls(options: AclFilter): Promise<DescribeAclResponse>
   deleteAcls(options: { filters: AclFilter[] }): Promise<DeleteAclResponse>
-  createAcls(options: { acls: AclEntry[] }): Promise<boolean>
+  createAcls(options: { acl: AclEntry[] }): Promise<boolean>
   deleteTopicRecords(options: { topic: string; partitions: SeekEntry[] }): Promise<void>
   logger(): Logger
   on(

diff --git a/types/tests.ts b/types/tests.ts
@@ -220,12 +220,12 @@ const runAdmin = async () => {
       resourceType: r.resourceType,
       resourceName: r.resourceName,
       resourcePatternType: r.resourcePatternType,
-      acls: r.acls,
+      acls: r.acl,
     })),
   })
 
   const createAcls = await admin.createAcls({
-    acls: [
+    acl: [
       {
         resourceType: AclResourceTypes.TOPIC,
         resourceName: 'topic-name',