Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing some exports on version 2.43.3 #440

Closed
salesfelipe opened this issue Feb 5, 2024 · 2 comments · Fixed by #446
Closed

Missing some exports on version 2.43.3 #440

salesfelipe opened this issue Feb 5, 2024 · 2 comments · Fixed by #446

Comments

@salesfelipe
Copy link

Hello there,

I've updated to the latest version of mappersmith to be able to use the keep-alive configs and I noticed that some files were not present on the new version.

In specific I was using:

import { Request } from 'mappersmith/request' import { MethodDescriptor } from 'mappersmith/method-descriptor'

Here is the error that I was receiving:

Screenshot 2024-02-02 at 18 37 32

From my quick search I believe that is only a matter of exporting it on:

https://github.com/tulios/mappersmith/blob/master/package.json#L14

But then I would like to ask first, wether this is intended, meaning that we shouldn't be using this components anymore and if not how can we proceed to fix it? If you agreed, I would love to contribute. :)

Best regards!

@klippx
Copy link
Collaborator

klippx commented Feb 12, 2024

@salesfelipe Thanks for the report. I can add a fix, for backwards compatiblity.

The idea is to change to:

< import { Request } from 'mappersmith/request' 
< import { MethodDescriptor } from 'mappersmith/method-descriptor'
> import { Request } from 'mappersmith' 
> import { MethodDescriptor } from 'mappersmith'

But this also failed (MethodDescriptor wasnt exported) so I am fixing that too :)

The reason is we moved to ESM which was not completely without pain.

@slavnycoder
Copy link

setErrorHandler is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants