Add a room_id param to GET /portal/:chat_id #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required when using the user_id param so the intent knows which room it should be checking permissions in. The integration manager is responsible for figuring out which room is the best for the context.
turt2live
added a commit
to turt2live/matrix-dimension
that referenced
this pull request
Oct 18, 2018
Requires mautrix/telegram#235 Puppeting is scheduled to be handled in #214 The TODO comments about asking for unbridge/permission denied will be handled in a later commit.
|
This doesn't do what I think it does |
turt2live
added a commit
to turt2live/mautrix-telegram
that referenced
this pull request
Oct 20, 2018
This is the proper way to fix mautrix#235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required when using the user_id param so the intent knows which room it should be checking permissions in. The integration manager is responsible for figuring out which room is the best for the context.