Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build fails] The vuex dependency leads to errors at building in Version 3.1.2 #10

Closed
egekorkan opened this issue May 28, 2020 · 3 comments
Labels
bug Something isn't working prio:high

Comments

@egekorkan
Copy link
Member

Comes up when

  • npm install
  • npm run electron:serve OR npm run electron:build

Problem

When the vuex dependency is installed in Version 3.1.2 by npm, multiple Errors are thrown during building (depending on wade-branch around 60 errors). They all have a similar reason (difference is only the involved variable), an throw in different files, e.g.:

137:42 Property 'currentTabId' does not exist on type 'CombinedVueInstance<Vue, unknown, unknown, { id: unknown; getTdTabbar: any; }, Readonly<Record<never, any>>>'.

Workaround

In package.json replace

vuex: "^3.1.1"

with

vuex: "3.1.1"

then run npm update vuex. Now building should work.

Fix

The workaround above is also applied to the ak_dev branch in private Fork and will be merged into the wade-master branch. Then the commit should be mentioned in this issue and the issue can be closed.

@egekorkan
Copy link
Member Author

I think this can be closed now, what do you think @neniman ?

@egekorkan egekorkan added bug Something isn't working prio:high labels May 31, 2020
@FadySalama
Copy link
Member

I think we can close this for now, we can re-visit it if we change how we store things in W-ADE . What do you think @egekorkan?

@egekorkan
Copy link
Member Author

yup the current way is not ideal but liveable... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio:high
Projects
None yet
Development

No branches or pull requests

2 participants