Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why breathable chains sometimes run when state is paused. #6

Open
tungs opened this issue Feb 8, 2017 · 0 comments
Open
Assignees

Comments

@tungs
Copy link
Owner

tungs commented Feb 8, 2017

In breathe.js 0.2.0, in breatheChain, sometimes handleGates is called when the state is paused, and there is no pause gate defined. This generally happens when a pause command propagates through subchains, apparently in these cases it does not suspend their resolution. I don't think this happens in breathe.js 0.1.7, though I would need to verify.

Currently handleGates creates a pause gate, which seems to prevent pausing issues, but this should be unnecessary if the chain is properly paused.

@tungs tungs self-assigned this Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant