Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with anime.js #4

Closed
varunarora opened this issue Mar 21, 2019 · 5 comments
Closed

Doesn't work with anime.js #4

varunarora opened this issue Mar 21, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@varunarora
Copy link
Contributor

I am using a pretty standard and popular animation library called anime.js. The animations don't seem to render. Am I doing something fundamentally wrong? Or is the library non-standard?

@tungs tungs self-assigned this Apr 22, 2019
@tungs tungs added the bug Something isn't working label Apr 22, 2019
@tungs
Copy link
Owner

tungs commented Apr 22, 2019

Looks like that the code in timecut/timesnap that overwrites requestAnimationFrame isn't passing a time value to the callback. It seems that anime.js relies on that time value. I'll work on a fix this week. Thanks for filing this issue!

For more information about requestAnimationFrame:
https://developer.mozilla.org/en-US/docs/Web/API/window/requestAnimationFrame
https://html.spec.whatwg.org/multipage/imagebitmap-and-animations.html#animation-frames

@tungs
Copy link
Owner

tungs commented Apr 23, 2019

Should be fixed in tungs/timesnap@7f2cbfd and da3a52a (and in v0.0.3). Please let me know if the new version still doesn't work. Thanks!

@varunarora
Copy link
Contributor Author

Oh awesome let me give this a shot!

@varunarora
Copy link
Contributor Author

WORKS! So excited! Thanks.

@tungs
Copy link
Owner

tungs commented Apr 29, 2019

Awesome! Glad that it works. Thanks for filing this!

@tungs tungs closed this as completed Apr 29, 2019
@huocaiit huocaiit mentioned this issue Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants