feat: eslint lint updates; use typescript parser for js files

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>

.eslintrc.js

@@ -1 +1,3 @@
+'use strict';
+
 module.exports = require('@tunnckocore/eslint-config/recommended');

.prettierrc.js

@@ -1 +1,3 @@
+'use strict';
+
 module.exports = require('@tunnckocore/prettier-config');

@hela/dev/src/configs/build/index.js

@@ -1,7 +1,7 @@
-const path = require('path');
-const utils = require('@tunnckocore/utils');
+import path from 'path';
+import utils from '@tunnckocore/utils';
 
-module.exports = (options) => {
+export default (options) => {
   const opts = { cwd: process.cwd(), ...options };
   const { exts, alias, workspaces } = utils.createAliases(opts.cwd);
   const ignores = []

@hela/dev/src/configs/bundle/index.js

@@ -1,7 +1,7 @@
-const path = require('path');
-const utils = require('@tunnckocore/utils');
+import path from 'path';
+import utils from '@tunnckocore/utils';
 
-module.exports = (options) => {
+export default (options) => {
   const opts = { cwd: process.cwd(), ...options };
   const { exts, alias, workspaces } = utils.createAliases(opts.cwd);
   const ignores = []

@hela/dev/src/configs/docs/index.js

@@ -1,6 +1,6 @@
-const utils = require('@tunnckocore/utils');
+import utils from '@tunnckocore/utils';
 
-module.exports = (options) => {
+export default (options) => {
   const opts = { cwd: process.cwd(), ...options };
   const { exts, alias, workspaces } = utils.createAliases(opts.cwd);
   const ignores = []

@hela/dev/src/configs/lint/index.js

@@ -1,6 +1,7 @@
-const utils = require('@tunnckocore/utils');
+import path from 'path';
+import utils from '@tunnckocore/utils';
 
-module.exports = (options) => {
+export default (options) => {
   const opts = { cwd: process.cwd(), ...options };
   const { exts, alias, workspaces } = utils.createAliases(opts.cwd);
   const ignores = []
@@ -14,7 +15,11 @@ module.exports = (options) => {
 
   // if monorepo setup
   if (isMonorepo) {
-    testMatch = Object.values(alias).map((source) => `${source}/**/*`);
+    testMatch = Object.values(alias).map((source) => {
+      const src = source.endsWith('src') ? path.dirname(source) : source;
+
+      return `${src}/**/*`;
+    });
   } else {
     testMatch =
       inputs.length > 0

@hela/dev/src/configs/test/index.js

@@ -1,13 +1,13 @@
 /* eslint-disable import/no-dynamic-require, global-require */
 
-const fs = require('fs');
-const path = require('path');
-const utils = require('@tunnckocore/utils');
-const isCI = require('is-ci');
-const picomatch = require('picomatch');
+import fs from 'fs';
+import path from 'path';
+import utils from '@tunnckocore/utils';
+import isCI from 'is-ci';
+import picomatch from 'picomatch';
 
 // eslint-disable-next-line max-statements
-module.exports = (options) => {
+export default (options) => {
   const opts = { cwd: process.cwd(), ...options };
   const { exts, workspaces, info, alias } = utils.createAliases(opts.cwd);
   const ignores = []

@hela/dev/src/index.js

@@ -97,8 +97,8 @@ function createCommand(name, description) {
       const configDir = path.join(__dirname, 'configs', name);
       const configPath = path.join(configDir, 'config.js');
 
-      // eslint-disable-next-line import/no-dynamic-require, global-require
-      const createConfig = require(configDir);
+      // const createConfig = require(configDir);
+      const { default: createConfig } = await import(configDir);
 
       const config = createConfig({ ...opts, ignores, input: inputs });
       const contents = `module.exports=${JSON.stringify(config)}`;

@hela/dev/test/index.js

@@ -1,4 +1,11 @@
-import { build, bundle, docs, lint, test as testCmd, runAll } from '../src';
+import {
+  build,
+  bundle,
+  docs,
+  lint,
+  test as testCmd,
+  runAll,
+} from '../src/index.js';
 
 test('command: build', async () => {
   expect(typeof build).toStrictEqual('function');

@tunnckocore/create-jest-runner/test/failing.test.js

@@ -1,4 +1,4 @@
-import runJest from './support/runJest';
+import runJest from './support/runJest.js';
 
 it('Works when it has failing tests', async () => {
   const resultString = await runJest('failing');

@tunnckocore/create-jest-runner/test/passing.test.js

@@ -1,4 +1,4 @@
-import runJest from './support/runJest';
+import runJest from './support/runJest.js';
 
 it('Works when it has only passing tests', async () => {
   const resultString = await runJest('passing');

@tunnckocore/create-jest-runner/test/skipped.test.js

@@ -1,4 +1,4 @@
-import runJest from './support/runJest';
+import runJest from './support/runJest.js';
 
 it('Works when it has skipped tests', async () => {
   const resultString = await runJest('skipped');

@tunnckocore/create-jest-runner/test/todo.test.js

@@ -1,4 +1,4 @@
-import runJest from './support/runJest';
+import runJest from './support/runJest.js';
 
 it('Works when it has todo tests', async () => {
   const resultString = await runJest('todo');

@tunnckocore/execa/test/index.js

@@ -1,4 +1,4 @@
-import execa, { exec, shell } from '../src';
+import execa, { exec, shell } from '../src/index.js';
 
 test('default export execa v2 and named {shell, exec}', () => {
   expect(typeof execa).toBe('function');

@tunnckocore/jest-runner-babel/test/index.js

@@ -1,4 +1,4 @@
-import runner from '../src/runner';
+import runner from '../src/runner.js';
 
 test('todo runner babel testing', () => {
   expect(typeof runner).toStrictEqual('function');

@tunnckocore/jest-runner-eslint/test/index.js

@@ -1,4 +1,4 @@
-import runner from '../src/runner';
+import runner from '../src/runner.js';
 
 test('todo jest-runner-eslint tests', () => {
   expect(typeof runner).toStrictEqual('function');

@tunnckocore/pretty-config/src/index.js

@@ -1,4 +1,4 @@
-import { resolveConfig, resolveConfigPath } from './utils';
+import { resolveConfig, resolveConfigPath } from './utils.js';
 
 export { resolveConfig, resolveConfigPath };
 

@tunnckocore/pretty-config/test/index.js

@@ -1,4 +1,4 @@
-import mod from '../src';
+import mod from '../src/index.js';
 
 test('todo tests for @tunnckocore/pretty-config package', async () => {
   expect(typeof mod).toStrictEqual('function');

@tunnckocore/utils/src/index.js

@@ -14,6 +14,8 @@ module.exports = {
   isMonorepo,
   testCoverage,
   coverageColor,
+  tsconfigResolver,
+  EXTENSIONS,
 };
 
 // we cannot test it because we are in monorepo where the cwd is.
@@ -276,3 +278,21 @@ function coverageColor(value, colors = {}) {
   }
   return 'green';
 }
+
+function tsconfigResolver(rootDir) {
+  /* istanbul ignore next */
+  const cwd = rootDir || process.cwd();
+  const { isMonorepo: isMono, workspaces } = getWorkspacesAndExtensions(cwd);
+  const TSCONFIG_ESLINT = path.join(cwd, 'tsconfig.eslint.json');
+  const TSCONFIG = path.join(cwd, 'tsconfig.json');
+  const project = [TSCONFIG_ESLINT, TSCONFIG].find((x) => fs.existsSync(x));
+
+  return isMono
+    ? [project].concat(
+        workspaces.reduce(
+          (acc, ws) => acc.concat(path.join(cwd, ws, '*', 'tsconfig.json')),
+          [],
+        ),
+      )
+    : project;
+}

configs/babel-preset/test/index.js

@@ -1,6 +1,6 @@
 const path = require('path');
 const { transformSync } = require('@babel/core');
-const config = require('../src');
+const config = require('../src/index.js');
 
 process.env.SELF_TEST_TUNNCKOCORE = 'yes';
 
@@ -12,17 +12,15 @@ test('to throw error when typescript: false', async () => {
   const opts = { typescript: false, presetEnv: false };
   const inputCode = `export const bar = (foo: number, bar: number) => {};`;
 
-  try {
+  const fn = () =>
     transformSync(inputCode, {
       babelrc: false,
       filename: 'fixture-foo.ts',
       presets: [[path.join(path.dirname(__dirname), 'src', 'index.js'), opts]],
     });
-  } catch (err) {
-    expect(err).toBeTruthy();
-    expect(err.name).toStrictEqual('SyntaxError');
-    expect(err.message).toMatch(/Unexpected token, expected/);
-  }
+
+  expect(fn).toThrow(SyntaxError);
+  expect(fn).toThrow(/Unexpected token, expected/);
 });
 
 test('to transform typescript properly', () => {

configs/browserslist-config/index.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = [
   'defaults',
   // 'current node', // disable temporarily, see https://github.com/amilajack/eslint-plugin-compat/issues/264

configs/browserslist-config/latest.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = [
   'last 1 Android version',
   'last 1 Chrome version',

configs/browserslist-config/modern.js

@@ -1 +1,6 @@
-module.exports = require('.').concat(['not ie <= 11', 'not ie_mob <= 11']);
+'use strict';
+
+module.exports = require('./index.js').concat([
+  'not ie <= 11',
+  'not ie_mob <= 11',
+]);

configs/eslint-config/index.js

@@ -1,13 +1,10 @@
 'use strict';
 
-const path = require('path');
-const { createAliases } = require('@tunnckocore/utils');
-
-const CWD = process.cwd();
-const { alias, workspaces } = createAliases(CWD);
-
+const { createAliases, tsconfigResolver } = require('@tunnckocore/utils');
 const airbnbBase = require('eslint-config-airbnb-base');
 
+const { alias, workspaces } = createAliases();
+
 // eslint-disable-next-line import/no-dynamic-require
 const bestPractices = require(airbnbBase.extends[0]);
 
@@ -61,6 +58,10 @@ const unicornRules = {
   // It is pretty common to name it `err`, and there is almost no reason to be any other.
   // https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/catch-error-name.md
   'unicorn/catch-error-name': ['error', { name: 'err' }],
+
+  // Doesn't work well in node-land. We have `.on/.off` emitters in Nodejs.
+  'unicorn/prefer-add-event-listener': 'off',
+  'unicorn/no-process-exit': 'error',
 };
 
 // Sindre's XO and mine preferences too.
@@ -93,7 +94,7 @@ const importRules = {
   'import/no-self-import': 'error',
 
   // Enable this sometime in the future when Node.js has ES2015 module support
-  // 'import/no-cycle': 'error'
+  // 'import/no-cycle': 'error',
 
   'import/no-useless-path-segments': ['error', { noUselessIndex: true }],
 
@@ -201,6 +202,7 @@ const eslintCommentsRules = {
   ],
 };
 
+// Additional rules that are specific and overiding previous
 const additionalChanges = {
   'no-extend-native': 'error',
   'no-use-extend-native/no-use-extend-native': 'error',
@@ -282,6 +284,27 @@ const additionalChanges = {
 
   'node/shebang': 'off',
   'import/prefer-default-export': 'off',
+
+  // Ensure more web-compat
+  // ! note that it doesn't work in CommonJS
+  // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md
+  'import/extensions': ['error', 'always', { ignorePackages: true }],
+  // ! note that it doesn't work in CommonJS
+  'node/file-extension-in-import': ['error', 'always'],
+
+  // ? Always use named exports. Enable?
+  // 'import/no-default-export': 'error',
+
+  // ? enable?
+  'import/exports-last': 'off',
+
+  // todo: Enable in future.
+  // Ensures everything is tested (all exports should be used).
+  // For cases when you don't want or can't test, add eslint-ignore comment!
+  // see: https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unused-modules.md
+  'import/no-unused-modules': 'off',
+
+  'import/no-useless-path-segments': ['error', { noUselessIndex: false }],
 };
 
 const importResolverAliasMap = Object.keys(alias).reduce((acc, key) => {
@@ -299,24 +322,34 @@ const EXTENSIONS = [
   '.js',
   '.jsx',
   '.js.flow',
+  '.md',
   '.mdx',
   '.json',
 ];
 
 module.exports = {
-  parser: 'babel-eslint',
+  // use typescript parser, always
+  parser: '@typescript-eslint/parser',
   parserOptions: {
-    ecmaVersion: 11, // ECMAScript 2020
-    requireConfigFile: true,
     sourceType: 'module',
-    ecmaFeatures: {
-      impliedStrict: true,
-      jsx: true,
-    },
-    babelOptions: {
-      configFile: path.join(CWD, 'babe-eslint.config.js'),
-    },
+    jsx: true,
+    project: tsconfigResolver(),
   },
+
+  // parser: 'babel-eslint',
+  // parserOptions: {
+  //   ecmaVersion: 11, // ECMAScript 2020
+  //   requireConfigFile: true,
+  //   sourceType: 'module',
+  //   ecmaFeatures: {
+  //     impliedStrict: true,
+  //     jsx: true,
+  //   },
+  //   babelOptions: {
+  //     configFile: path.join(CWD, 'babe-eslint.config.js'),
+  //   },
+  // },
+
   // parser: path.join(__dirname, 'buntis-parser.js'),
   // parserOptions: {
   //   loc: true,
@@ -332,10 +365,14 @@ module.exports = {
       allowModules: Object.keys(alias),
       tryExtensions: EXTENSIONS,
     },
+    'import/parsers': {
+      '@typescript-eslint/parser': ['.ts', '.tsx', '.d.ts'],
+    },
     'import/resolver': {
       node: {
         paths: workspaces,
         extensions: EXTENSIONS,
+        tryExtensions: EXTENSIONS,
         moduleDirectory: ['node_modules']
           .concat(workspaces)
           .concat(Object.values(alias)),
@@ -380,11 +417,11 @@ module.exports = {
     'eslint-comments',
   ],
   rules: {
-    ...additionalChanges,
     ...unicornRules,
     ...promiseRules,
     ...importRules,
     ...nodeRules,
     ...eslintCommentsRules,
+    ...additionalChanges,
   },
 };