Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Dank UI - Discussion #7

Closed
dotvhs opened this issue Jan 10, 2019 · 17 comments
Closed

Dank UI - Discussion #7

dotvhs opened this issue Jan 10, 2019 · 17 comments
Labels
design Changes to the design of the app

Comments

@dotvhs
Copy link

dotvhs commented Jan 10, 2019

First of all, I'd like to say that I do really like Dank in general, in terms of UI and the feeling. However, there are few things I think might or even should be changed for more consistency and better UX. So I created this thread for discussion.

Something I think I know how should be fixed:
image
Number of upvotes - while it is something that makes Dank stand out from the crowd, I do think that number should be shown after the title, not before it, at least as an option. Here's an example:
image

It will be easier to read the titles that don't have similar score number (my eyes won't have to jump left/right anymore, to read the title). Here's an example that shows what makes me feel uncomfortable reading the titles:
image

Another thing on the same screen is that horizontal bar with sorting button. I do like how this button looks like, but I don't like that it is alone, making almost whole line of wasted space and it makes no sense that it's fixed to that view:
image
image

What's the point of Toolbar having a shadow when it's not really covering anything since that grey bar with button that changes sorting is not moving at all. I honestly don't have a good idea what could be done for it to make more sense for now.

The last thing I find a bit annoying is way more minor than the rest. In comments view when there's picture on top of the screen, there is also close button in the left corner and of course there should be icon to close but sometimes it's obscuring something which does not really look good, here's an example:
screenshot_20190111-001650

I hope I did not sound harsh nor rude, I do have issues with explaining things in a gentle manner in foreign language. Sorry if I did.

@mvietri
Copy link

mvietri commented Jan 11, 2019

I didn't understand quite well the 'Toolbar shadow' issue but +1 to move the vote count and the close icon on the image.

Also, I notice there is no timestamp (i.e. '2 days ago' on the items list)

@dotvhs
Copy link
Author

dotvhs commented Jan 11, 2019

Ah yeah, I wrote that very poorly, so I will rephrase that:
Top part of app contains two things, a toolbar (that darker part with app/subreddit name etc) and that bar underneath it which contains only the button for switching sort type.

And both of them are fixed in place - they are pinned to that position, does not matter if you scroll - it's still on top of the screen. I asked what's the point of the shadow underneath the toolbar when toolbar itself is on top of the item that never moves and shadow on elements like this is used to give a sense of feeling that it is floating on top of other elements.

In short words - I don't like that there is quite big part of the screen pinned with quite a lot of space wasted.

@mvietri
Copy link

mvietri commented Jan 11, 2019

Ok maybe the sort button should be part of the scrollable content. Will that work according to your designs?

@dotvhs
Copy link
Author

dotvhs commented Jan 11, 2019

That's probably the easiest way to fix it but also it will make the button unreachable when someone scrolls far.

@saket
Copy link

saket commented Jan 11, 2019

I like the idea of moving the scores to the end. I kept them on the left so that my eyes could scan the scores easily.

Any better ideas on improving the sorting button? I don't like its placement either, but couldn't come up with a better design.

@mvietri
Copy link

mvietri commented Jan 11, 2019

Any better ideas on improving the sorting button? I don't like its placement either, but couldn't come up with a better design.

Well since the refresh button is in the upper toolbar we can move that button next to the sort button or move the sort button to the other toolbar. In other words, put the button that are related together.

Another option for me is to keep that bar (the one below the main toolbar) and put all the subreddit options there, like sort, (un)subscribe, refresh, submit link/post.

@Tunous Tunous added the design Changes to the design of the app label Jan 12, 2019
@saket
Copy link

saket commented Jan 13, 2019

And both of them are fixed in place - they are pinned to that position, does not matter if you scroll - it's still on top of the screen. I asked what's the point of the shadow underneath the toolbar when toolbar itself is on top of the item that never moves and shadow on elements like this is used to give a sense of feeling that it is floating on top of other elements.

The initial plan was to hide either both of them or just the sorting bar when the content list is scrolled.

Well since the refresh button is in the upper toolbar we can move that button next to the sort button or move the sort button to the other toolbar. In other words, put the button that are related together.

There's very little space on the toolbar. Subreddits with long name get truncated very easily. Additionally, there's the subscribe button also sits next to the sorting button.

@mufeedali
Copy link

@saket why not make the bar with sort a scrollable view with buttons like wiki, subscribe, etc?

@saket
Copy link

saket commented Jan 15, 2019

@lastweakness are you talking about the bar below the subreddit name?

@mufeedali
Copy link

@saket yes

@saket
Copy link

saket commented Jan 15, 2019

That's a good idea. Will do that once I add more options to the bar. Thanks!

@Minnona
Copy link

Minnona commented Nov 11, 2019

May I suggest remembering sorting order per subreddit as well, currently it just resets everything to "Best" every time I relaunch the app.

@Minnona
Copy link

Minnona commented Nov 11, 2019

I think it would be nice to have more colors, for example: having subreddits colored on the frontpage/popular to differentiate them more easily.
Another suggestion is to hide "R/" from subreddit names to save some space.
Screenshot_20191111-203128

@Minnona
Copy link

Minnona commented Nov 12, 2019

Found myself missing pressing back button 2 times in a row to close the app, sometimes I close it accidentally.

@Tunous
Copy link
Owner

Tunous commented Nov 12, 2019

Hey @elenmerbau thank you for the comments. Would you mind creating a new issue for each suggestion to make them more focused and easier to find in the future? That would help a lot.

@Minnona
Copy link

Minnona commented Nov 12, 2019

@Tunous aight, no problems, will do after I finish cookong :p

@Tunous
Copy link
Owner

Tunous commented Jun 15, 2020

Moved the missing topic to separate issue: #255 The other ones are in #208 and #119. Not sure about votes position but that perhaps will return to us somewhere :)

Closing this as I prefer to have more focused issues.

@Tunous Tunous closed this as completed Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design Changes to the design of the app
Projects
None yet
Development

No branches or pull requests

6 participants