Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MultiSwipeActionView for multiple actions #33

Merged
merged 9 commits into from
Oct 29, 2023

Conversation

newhinton
Copy link
Contributor

Screenshot_20231004_115140

This updates this library to a newer gradle version, aswell as java and kotlin.
This implements a specific container, that allows for two children to be treated as two distinct actions.
Technically it allows for arbitrary amounts of elements, but only the first child (for the left actions) and the last child (for the right actions) are used as a divider.

What works:

  • Callback for halfway-action (left&right)

What doesn't work:

  • "Sticky" halfway-point. (The main view always returns to the initial state)
  • Maven publishing. The gradle-syntax changed, and i dont know how to test this

Copy link
Owner

@Tunous Tunous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull requests. I've reviewed your code and left few code changes requests.

@newhinton newhinton requested a review from Tunous October 22, 2023 11:57
Copy link
Owner

@Tunous Tunous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good now. I've only pushed a small fix where swipe position was incorrect.
Will try to figure out the new publishing workflow and hopefully release a new version with your changes.

@Tunous
Copy link
Owner

Tunous commented Oct 29, 2023

Closes #19

@Tunous Tunous merged commit 82323b9 into Tunous:master Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants