-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MultiSwipeActionView for multiple actions #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull requests. I've reviewed your code and left few code changes requests.
library/src/main/kotlin/me/thanel/swipeactionview/SwipeActionView.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/me/thanel/swipeactionview/SwipeActionView.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/me/thanel/swipeactionview/SwipeActionView.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/me/thanel/swipeactionview/SwipeActionView.kt
Outdated
Show resolved
Hide resolved
…iew.kt Co-authored-by: Łukasz Rutkowski <lukus178@gmail.com>
…iew.kt Co-authored-by: Łukasz Rutkowski <lukus178@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good now. I've only pushed a small fix where swipe position was incorrect.
Will try to figure out the new publishing workflow and hopefully release a new version with your changes.
Closes #19 |
This updates this library to a newer gradle version, aswell as java and kotlin.
This implements a specific container, that allows for two children to be treated as two distinct actions.
Technically it allows for arbitrary amounts of elements, but only the first child (for the left actions) and the last child (for the right actions) are used as a divider.
What works:
What doesn't work: