Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI can trade own planets to player even there is no need to do that. #55

Closed
tuomount opened this issue Jun 28, 2017 · 1 comment
Closed

AI can trade own planets to player even there is no need to do that. #55

tuomount opened this issue Jun 28, 2017 · 1 comment
Labels
AI Game AI related issue bug Verified bug which needs fixing Wait for verify Issue has been implemented but needs verification that it works.
Milestone
rel-0-0-6

Comments

@tuomount
Copy link
Owner

AI just now compares values of trading items and if those matching it will make the trade. Planets should be tradeable only when making a peace contract from war.
@tuomount tuomount added bug Verified bug which needs fixing AI Game AI related issue labels Jun 28, 2017
tuomount added a commit that referenced this issue Jun 28, 2017
@tuomount
#55 AIs no doesn't trade planets or fleets unless peace is on trade too.
c978943 
Adds JUnit for new methods.
@tuomount tuomount added the Wait for verify Issue has been implemented but needs verification that it works. label Jun 28, 2017
tuomount added a commit that referenced this issue Jun 29, 2017
@tuomount
#55 Adds checks to correct offering lists.
ef7a364 
This also adds JUnit that Fleet or Planet is not traded
too easily.
@tuomount tuomount added this to the rel-0-0-6 milestone Jul 15, 2017
tuomount added a commit that referenced this issue Jul 15, 2017
@tuomount
#55 Fixes planet and fleet trading.
31d404f 
Now if clause is much more simpler. Planet and fleet
trades are now considered if isWar and offer contains peace.
Otherwise they are treat as insults.
@tuomount
Copy link
Owner Author

This seems to work now too. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AI Game AI related issue bug Verified bug which needs fixing Wait for verify Issue has been implemented but needs verification that it works.
Projects
None yet
Milestone
rel-0-0-6
Development

No branches or pull requests
1 participant
@tuomount