Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify file format based on filename #1

Closed
pims opened this issue May 23, 2018 · 1 comment
Closed

Identify file format based on filename #1

pims opened this issue May 23, 2018 · 1 comment

Comments

@pims
Copy link

pims commented May 23, 2018

Hi there,

I was very excited to try Rotor this morning, using rotor version 0.16.0 and ran into a small documentaion/UX issue:

While following the instructions in the README to start with Flat Files Service Discovery, the README doesn’t mention that to use a YAML file – in the format described – one needs to specify the --format=yaml flag to Rotor.

Otherwise Rotor tries to parse the YAML as JSON, which is the default value in the github.com/turbinelabs/codec library and spits out file: invalid character ' ' in numeric literal errors with no obvious clue as to what is causing this.

I looked into trying to guess the file format from the filename, but it looks it would require quite a few changes to the way flags are parsed.

@9len
Copy link
Contributor

9len commented May 23, 2018

Hi @pims,

We'll update the README to be more precise, but will continue to require that the format be explicitly specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants