login redirect strips query params

[atbinf]

When going to a url with query params and not authenticated, the came_from param has the query params stripped. Many times links may be provided to uses in emails to specific pages with query params, for example an id of the entity to display. Is there a reason the params are stripped?

I was able to patch this by mofifying line 116 of tg.configuration.auth.fastform.py from

path_info =environ['PATH_INFO']
to

path_info = '%s?%s' % (environ['PATH_INFO'],environ['QUERY_STRING'])

I am not sure if this is the best way to handle it but it is a hold over untill a fix can be added to the code base.

[amol-]

I'll take a look at it. In the mean time you can easily avoid the issue, without having to modify fastform code, by using positional arguments:

TG dispatches both /url?a=1&b=2 and /url/1/2 to the same controller, so you can easily avoid facing the issue by providing all the arguments as positional arguments.

[atbinf]

Good point, I'll give positional arguments a try. Maybe this isn't a bug after all.

[amol-]

Commit c8d073d should resolve the issue by forwarding GET paremeters in came_from