Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Error in gcp_sql_database if instance is not running Closes #584 #586

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Fixed Error in gcp_sql_database if instance is not running Closes #584 #586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
462f294
Fixed Error in gcp_sql_database if instance is not running Closes #584
ParthaI May 16, 2024
7cc9d9e
Update table_gcp_sql_database.go
misraved Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions gcp/table_gcp_sql_database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,15 @@ func listSQLDatabases(ctx context.Context, d *plugin.QueryData, h *plugin.Hydrat
instance := h.Item.(*sqladmin.DatabaseInstance)

// ERROR: rpc error: code = Unknown desc = googleapi: Error 400: Invalid request: Invalid request since instance is not running., invalid
// Return nil, if the instance not in running state
if instance.State != "RUNNABLE" {
// Return nil, if the instance is not in Runnable state.
// ActivationPolicy specifies when the instance is activated.
// - SQL_ACTIVATION_POLICY_UNSPECIFIED Unknown activation plan.
// - ALWAYS The instance is always up and running.
// - NEVER The instance never starts.
// - ON_DEMAND The instance starts upon receiving requests.(Deprecated)
// https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1/instances#SqlActivationPolicy

if instance.State != "RUNNABLE" || instance.Settings.ActivationPolicy != "ALWAYS" {
return nil, nil
}

Expand Down