Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle ssl password #4152

Merged
merged 4 commits into from
Mar 15, 2024
Merged

feat: handle ssl password #4152

merged 4 commits into from
Mar 15, 2024

Conversation

burahimu
Copy link
Contributor

@burahimu burahimu commented Feb 26, 2024

We figured out that steampipe does not handle private key protected with a passphrase.
This should fix that by adding sslpassword and ssl_passphrase_command options (and ssl_passphrase_command_supports_reload)

Note

The server.key content must contains Proc-Type and DEK-Info headers.

It is possible by adding -traditional to openssl command:

openssl genrsa -aes256 -out $STEAMPIPE_INSTALL_DIR/db/14.2.0/data/server.key -passout pass:steampipe -traditional 2048

Add database SSL password support for encrypted private key in order to handle your own certificates.
@CLAassistant
Copy link

CLAassistant commented Feb 26, 2024

CLA assistant check
All committers have signed the CLA.

@e-gineer
Copy link
Contributor

e-gineer commented Mar 1, 2024

This is a good feature and PR. Some questions:

  • Should this focus have CLI arguments etc? It's consistent, but perhaps simpler to start with just the env var for this (edge) case.
  • If the password env var is set, would that affect our automatic certificate creation? How do we make that behavior clear?

@burahimu
Copy link
Contributor Author

burahimu commented Mar 4, 2024

Should this focus have CLI arguments etc? It's consistent, but perhaps simpler to start with just the env var for this (edge) case.

Yes it can be set only in env var as a first step. Would you like this behavior?

If the password env var is set, would that affect our automatic certificate creation? How do we make that behavior clear?

For instance, I believe steampipe will override the server.key file with no passphrase.
The certificate renew will be specific to the authority managing the certificates, unless you want steampipe to manage the case?

@kaidaguerre
Copy link
Contributor

@burahimu

Yes it can be set only in env var as a first step. Would you like this behavior?

Yes, I think for the initial implementation, just an env var would be good

@burahimu
Copy link
Contributor Author

burahimu commented Mar 8, 2024

Done ✅

@kaidaguerre kaidaguerre merged commit 34ba9fd into turbot:main Mar 15, 2024
58 checks passed
@kaidaguerre
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants