Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge VoxelMap (1.13.2 - 1.16.3) doesn't recognize worlds #8

Closed
Tracked by #6
turikhay opened this issue Mar 24, 2023 · 1 comment · Fixed by #11
Closed
Tracked by #6

Forge VoxelMap (1.13.2 - 1.16.3) doesn't recognize worlds #8

turikhay opened this issue Mar 24, 2023 · 1 comment · Fixed by #11
Labels
bug Something isn't working VoxelMap

Comments

@turikhay
Copy link
Owner

turikhay commented Mar 24, 2023

Explanation and fix

VoxelMap on Forge 1.13.2 - 1.16.4 sends ambiguous request packet.
By default, we send a standard response, which is supported by later versions of VoxelMap, but in this case the mod expects different response.
If you use older VoxelMap versions, please install ProtocolLib alongside MapModCompanion in your Bukkit/Spigot/Paper server.

Original issue

Fabric versions work fine

Confirmed Minecraft versions:

  • 1.13.2
  • 1.14.4
  • 1.15.2
  • 1.16.1
  • 1.16.2
  • 1.16.3
Client
[19:11:06.835] [Client thread/INFO] [STDERR/]: [com.mamiyaotaru.voxelmap.forgemod.WorldIDPacket:decode:45]: Failed to read message: java.lang.IndexOutOfBoundsException: readerIndex(2) + length(42) exceeds writerIndex(7): PooledUnsafeDirectByteBuf(ridx: 2, widx: 7, cap: 7)
Server
tests_e2e-proxy-1          | [19:11:06 INFO] [MapModCompanion - worldinfo:world_id]: [worldinfo:world_id] Data sent from turikhay to net.md_5.bungee.ServerConnection@3fb9ef3b (channel worldinfo:world_id):
tests_e2e-proxy-1          | [19:11:06 INFO] [MapModCompanion - worldinfo:world_id]: [worldinfo:world_id] Data (0): [0, 42, 0]
tests_e2e-server-1         | [19:11:06 INFO]: [MapModCompanion - worldinfo:world_id] Sending world_id packet to turikhay: [0, 42, 4, 49, 51, 51, 55]
tests_e2e-proxy-1          | [19:11:06 INFO] [MapModCompanion - worldinfo:world_id]: [worldinfo:world_id] Data sent from net.md_5.bungee.ServerConnection@3fb9ef3b to turikhay (channel worldinfo:world_id):
tests_e2e-proxy-1          | [19:11:06 INFO] [MapModCompanion - worldinfo:world_id]: [worldinfo:world_id] Data (0): [0, 42, 4, 49, 51, 51, 55]
tests_e2e-proxy-1          | [19:11:06 INFO] [MapModCompanion - worldinfo:world_id]: [worldinfo:world_id] Intercepting world_id packet sent to turikhay (channel worldinfo:world_id): PrefixedId{prefixLength=1, id=1337} -> PrefixedId{prefixLength=1, id=1337}
@turikhay turikhay added the bug Something isn't working label Mar 24, 2023
@turikhay turikhay changed the title Forge VoxelMap (1.13.2 - 1.16.3) doesn't recognize the world Forge VoxelMap (1.13.2 - 1.16.3) doesn't recognize worlds Mar 24, 2023
@turikhay turikhay mentioned this issue Mar 24, 2023
3 tasks
This was referenced Mar 25, 2023
@turikhay turikhay pinned this issue Mar 25, 2023
@turikhay
Copy link
Owner Author

turikhay commented Mar 31, 2023

Some time ago I've assembled this to better visualize packet structure of different mods. Thick borders mark the case in which we need to know the client's protocol version.

Download .odt

@turikhay turikhay unpinned this issue Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VoxelMap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant