Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttom "CKG Edit" does not show custom translation in Chrome #678

Open
mschlenstedt opened this issue Sep 13, 2022 · 3 comments
Open

Buttom "CKG Edit" does not show custom translation in Chrome #678

mschlenstedt opened this issue Sep 13, 2022 · 3 comments

Comments

@mschlenstedt
Copy link
Contributor

When setting a custom translation the button isn't translated in Chrome correctly. Only the title (which is a popup in Chrome) will be translated:

conf/plugin_lang/ckgedit/de/lang.php:

$lang['btn_fck_edit']          = 'WYSIWYG Editor';

image

Changing line /lib/plugins/ckgedit/action/meta.php:430 in my installation, which is

$button = '&nbsp;<button name="do[cancel]" type="submit" class="button" title="' . $title .'" id="edbtn__edit" value="CKG Edit" ' . $disabled. ' style = "' .$dwedit_only.'" onclick="return setDWEditCookie(1, this);"/>CKG Edit</button>&nbsp;';
here in the sources, does the trick:

$button = '&nbsp;<button name="do[cancel]" type="submit" class="button" title="' . $title .'" id="edbtn__edit" value="CKG Edit" ' . $disabled. ' style = "' .$dwedit_only.'" onclick="return setDWEditCookie(1, this);"/>' . $title .'</button>&nbsp;';
@turnermm
Copy link
Owner

This is the name of the plugin in the same way that Dokuwiki is the name of the wiki

@mschlenstedt
Copy link
Contributor Author

mschlenstedt commented Sep 13, 2022

But why don't make it configurable via user translation as shown above?! Using a fix string is not very clever in my point of view.

I just replaced the fix string with $title. No big deal.

@turnermm
Copy link
Owner

Then make a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants