Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

column names differ from what sqlite would produce, confusing clients. #1329

Closed
glommer opened this issue Apr 19, 2024 · 0 comments · Fixed by #1330
Closed

column names differ from what sqlite would produce, confusing clients. #1329

glommer opened this issue Apr 19, 2024 · 0 comments · Fixed by #1330
Labels
bug Something isn't working

Comments

@glommer
Copy link
Contributor

glommer commented Apr 19, 2024

Ref: fermyon/feedback#52

the issue is that the column names we produce are different than what sqlite produces. This can lead to confusing behavior if the user tries to get the columns by name.

For the query "select count(*) from foo", we receive the query as-is:

2024-04-19T00:02:07.626840Z DEBUG request{method=POST uri=/v2/pipeline version=HTTP/1.1}: libsql_server::hrana::http: pipeline:{ Hrana2, Execute(ExecuteStreamReq { stmt: Stmt { sql: Some("select count(*) from foo"), sql_id: None, args: [], named_args: [], want_rows: Some(true), replication_index: Some(1) } }) }

when it is time to execute_query, we produce:

2024-04-19T00:02:07.627181Z DEBUG libsql_server::connection::program: executing query: SELECT count (*) FROM foo;

Somewhere in the query parsing we end up adding a space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants