Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Storage GetReader Range Support #1073

Closed
pcfreak30 opened this issue Jan 25, 2024 · 1 comment
Closed

S3 Storage GetReader Range Support #1073

pcfreak30 opened this issue Jan 25, 2024 · 1 comment

Comments

@pcfreak30
Copy link

Is your feature request related to a problem? Please describe.
I needed the ability to pass the range (partial content) to the s3 options in GetReader

Describe the solution you'd like
I have created it LumeWeb@3615bc5

Describe alternatives you've considered
N/A

Can you provide help with implementing this feature?
See LumeWeb@3615bc5

Additional context
I have not made a PR as I want feedback/discussion and potentially have the team implement it in their own way if they feel they need to.

@Acconut
Copy link
Member

Acconut commented Jan 26, 2024

There has been a discussion in #1048 about adding support for ranged GET requests. The result was that we first need to find a good API design for this, which suits all storage implementations. Using context, like you did, is possible but not my preferred option because context values should not be used to implement optional parameters. I would rather have storages implement an explicit method for retrieving content with ranges.

I am going to close this issue in favor of #1064. Feel free to comment over there and let us know what you think.

@Acconut Acconut closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants