Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All components in the loading state should be unclickable and disabled #1853

Closed
muchenfine opened this issue Dec 15, 2021 · 9 comments · Fixed by #1856
Closed

All components in the loading state should be unclickable and disabled #1853

muchenfine opened this issue Dec 15, 2021 · 9 comments · Fixed by #1856

Comments

@muchenfine
Copy link

muchenfine commented Dec 15, 2021

TuSimple/naive-ui version (版本)

2.22.0

Vue version (Vue 版本)

3.2.26

Browser and its version (浏览器及其版本)

chrome

System and its version (系统及其版本)

window

Node version (Node 版本)

16

Reappearance link (重现链接)

https://codesandbox.io/api/v1/sandboxes/define

Reappearance steps (重现步骤)

1.The loading state of the switch component is still clickable
2.The style in loading state should be is disabled style

Expected results (期望的结果)

All components in the loading state should be unclickable and disabled ,
The style in loading state should be is disabled style

Actual results (实际的结果)

1.The loading state of the switch component is still clickable
2.The style in loading state should be is disabled style

Remarks (补充说明)

@github-actions github-actions bot added the untriaged need to sort label Dec 15, 2021
@muchenfine
Copy link
Author

At present, the switch can still be clicked in the loading state. I think all components should be consistent

@Talljack
Copy link
Contributor

select loading也是吧

@muchenfine
Copy link
Author

@07akioni @Talljack Yes, and I think that in loading state, it should be in the same style as disabled

@07akioni
Copy link
Collaborator

select loading也是吧

Don't change select now. It needs further consideration.

@Talljack
Copy link
Contributor

select loading也是吧

Don't change select now. It needs further consideration.
okay

@muchenfine
Copy link
Author

@07akioni @Talljack 是否考虑先把loading的css样式改为disabled的样式

@Talljack
Copy link
Contributor

Talljack commented Dec 16, 2021

@07akioni @Talljack 是否考虑先把loading的css样式改为disabled的样式

我们需要先对一下哪些组件需要修改,在考虑修改方案 @07akioni

@07akioni
Copy link
Collaborator

@07akioni @Talljack 是否考虑先把loading的css样式改为disabled的样式

这个不能一蹴而就,要循序渐进,一点一点来

@07akioni
Copy link
Collaborator

@07akioni @Talljack 是否考虑先把loading的css样式改为disabled的样式

我们需要先对一下哪些组件需要修改,在考虑修改方案 @07akioni

Switch 是合理的,改了没问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants