Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size too small #2461

Open
Akeel1994 opened this issue Apr 26, 2022 · 3 comments
Open

Font size too small #2461

Akeel1994 opened this issue Apr 26, 2022 · 3 comments

Comments

@Akeel1994
Copy link

Hey, I've a low vision and even the biggest available font size is slightly too small to read the feed. Please add more font sizes. Suggestion: maybe you could let the user choose the size between e.g. 10 and 40. So everyone could find the right size. thank you!

@Gryzor
Copy link
Collaborator

Gryzor commented Apr 28, 2022

@Akeel1994 What device do you have? (I am not a dev on this project) but from what I see, there's nothing special about Tusky when it comes to font sizes other than them being correctly defined in sp (instead of dp). Then each device can/will (through the Accessibility panel in Settings) increase (or decrease) the "normal" font size.

Some devices are notably limited in this, offering merely two to four values, whereas Samsung devices, tend to offer much more granularity and font sizes.

@Akeel1994
Copy link
Author

@Akeel1994 What device do you have? (I am not a dev on this project) but from what I see, there's nothing special about Tusky when it comes to font sizes other than them being correctly defined in sp (instead of dp). Then each device can/will (through the Accessibility panel in Settings) increase (or decrease) the "normal" font size.

Some devices are notably limited in this, offering merely two to four values, whereas Samsung devices, tend to offer much more granularity and font sizes.

Hey, I'm using a Pixel 6 Pro. On this device it's not just big enough even with the biggest setting. So more settings would be appreciated.

@Gryzor
Copy link
Collaborator

Gryzor commented Apr 28, 2022

@Akeel1994 Understood. Well... to be honest the developers would have no way of making this happen short of re-redesigning most of the screens, or with quite a bit of work, but I'm more than happy to stand corrected.

I just looked at a OnePlus 6 and it only offers 4 values: Small, Normal(default), Large, and Largest; I believe this is the Android default (as evidenced by your Pixel 6 Pro running stock Android).
On a Samsung S20 there are eight values to chose from! But this is probably a Samsung customization.

Anyway, I think you're absolutely correct that a bigger font would be nice, but I don't know how the project maintainers/devs will want to approach something like this.

nikclayton added a commit that referenced this issue Jun 29, 2023
Font scaling is applied in addition to any scaling set in Android system preferences. So if the user set the Android font size to largest (a 1.3x increase) and then sets the preference to 120%, the total change is 1.56x.

Create SliderPreference to adjust the preference.

- Use Slider, which supports float values and step sizes > 1
- Display the selected value in the preference's summary
- Provide buttons to increment / decrement the value

Restart the activity if the preference changes so that the user sees the impact of the change immediately. Fix a bug in PreferencesActivity where the "EXTRA_RESTART_ON_BACK" intent was never processed. Fix this to ensure that other activities are restarted so the new font scale takes effect.

Implement the scaling in BaseActivity by overriding onAttachBaseContext, and providing a wrapped context with the font scaling applied.

Fixes #2982, #2461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants