-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade OkHttp, add Conscrypt #1083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be a breaking thing but I support it. Just have concerns about the size and how many instances may break.
app/src/main/java/com/keylesspalace/tusky/TuskyApplication.java
Outdated
Show resolved
Hide resolved
implementation 'com.squareup.okhttp3:logging-interceptor:3.12.0' | ||
implementation 'com.squareup.okhttp3:okhttp:3.13.1' | ||
implementation 'com.squareup.okhttp3:logging-interceptor:3.13.1' | ||
implementation "org.conscrypt:conscrypt-android:2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you measure the size change already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Size of Tusky 5.1 apk: 3.749kB
size apk with Conscrypt: 6.986kB (download size will be much smaller for Google Play users because of App Bundles)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's 2x increase, I don't think many people will notice because it's still quite small.
instances that don't support TLS 1.2 x_X must be the worst admin ever |
Well, true, maybe it would even motivate some people. I think it's good to go then. |
I tried it out with this interceptor and TLS 1.3 works on all Android versions except 5. No idea why it does not work there, but there is also no reason to investigate further, TLS 1.2 is fine. |
this disables TLS 1 and 1.1 and enables TLS 1.3
closes #945