-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drafts v2 #2032
Drafts v2 #2032
Conversation
connyduck
commented
Jan 5, 2021
•
edited
Loading
edited
- complete clean rewrite of the draft feature
- the old draft feature is kept intact, so users can still use their old drafts (will remove it in a later release)
- an info dialog will tell users where to find the old drafts (only if they have some)
- gets rid of ancient Java code with AsyncTasks
- all saved information (content warning, attachments, polls) is shown on the draft preview
- only one network request per media file when restoring a draft (instead of one for the file and one for the description)
- Fixes a bug where media descriptions can get lost when restoring a draft
- Fixes a bug where restored media would get uploaded multiple times when the screen is rotated on ComposeActivity
- since I did not want to write code with the deprecated kotlin syntethic views, this introduces Viewbinding. I intend to convert everything to Viewbinding
- once the old draft feature is removed, the code should be a lot cleaner and faster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am yet to test it somehow but looking at code it's really nice!
It was kinda hard to hunt down all the relevant commits so I think it would be great to squash it into 2-3 commits and maybe also rebase it?
I'm fine with view binding, I think it's the most painless options for us right now.
app/src/main/java/com/keylesspalace/tusky/components/drafts/DraftsActivity.kt
Show resolved
Hide resolved
app/src/main/java/com/keylesspalace/tusky/components/drafts/DraftMediaAdapter.kt
Show resolved
Hide resolved
Here are some other things:
|
What about other comments I left? |
Oh. Thx 😅
I changed nothing there, it was always this way. I think it is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!