-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a menu option to mute / filter a hashtag from a status list #2882
Conversation
Good idea, but it always shows that a hashtag is not muted initially even if I open the timeline of a muted hashtag. |
I thought about that, and thought that there was no way to get to the timeline of a muted hashtag after you'd muted it, without unmuting it first. So... how do you get to the timeline of a muted hashtag? |
|
Thanks. Fixed. I'm not sold on the icons though. Technically they are the ones for mute / unmute, but I'm not sure they work in context. |
Un/muting uses the "home" filter
Check the user's filters to see if the tag is already filtered from HOME. If it is then the initial button is to unmute it. If it isn't then the initial button is to mute it.
I think the icons are fine. One thing that is now very weird and irritating: The two icons (mute and follow) appear at different times. Can you do it so the both appear at the same time? |
- Initial state shows the "mute" option, disabled - Update the state after the API call completes
…to mute-hashtag
Done -- the icon appears immediately, but is initially disabled, then adjusts when the API call completes. |
Nice! |
Un/muting uses the "home" filter