Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a menu option to mute / filter a hashtag from a status list #2882

Merged
merged 5 commits into from
Dec 5, 2022
Merged

Add a menu option to mute / filter a hashtag from a status list #2882

merged 5 commits into from
Dec 5, 2022

Conversation

nikclayton
Copy link
Contributor

Un/muting uses the "home" filter

@connyduck
Copy link
Collaborator

Good idea, but it always shows that a hashtag is not muted initially even if I open the timeline of a muted hashtag.

@nikclayton
Copy link
Contributor Author

I thought about that, and thought that there was no way to get to the timeline of a muted hashtag after you'd muted it, without unmuting it first.

So... how do you get to the timeline of a muted hashtag?

@connyduck
Copy link
Collaborator

  • from a public timeline (it is only muted on home after all)
  • via search

@nikclayton
Copy link
Contributor Author

  • from a public timeline (it is only muted on home after all)
  • via search

Thanks. Fixed.

I'm not sold on the icons though. Technically they are the ones for mute / unmute, but I'm not sure they work in context.

Nik Clayton added 2 commits December 2, 2022 18:32
Check the user's filters to see if the tag is already filtered from HOME.

If it is then the initial button is to unmute it. If it isn't then the
initial button is to mute it.
@connyduck
Copy link
Collaborator

I think the icons are fine.

One thing that is now very weird and irritating: The two icons (mute and follow) appear at different times. Can you do it so the both appear at the same time?

Nik Clayton added 3 commits December 3, 2022 14:37
- Initial state shows the "mute" option, disabled
- Update the state after the API call completes
@nikclayton
Copy link
Contributor Author

I think the icons are fine.

One thing that is now very weird and irritating: The two icons (mute and follow) appear at different times. Can you do it so the both appear at the same time?

Done -- the icon appears immediately, but is initially disabled, then adjusts when the API call completes.

@connyduck
Copy link
Collaborator

Nice!

@connyduck connyduck merged commit 424326f into tuskyapp:develop Dec 5, 2022
@nikclayton nikclayton deleted the mute-hashtag branch December 5, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants