Resets the paging3 changes of 3159 back to the (java) fragment code

[Lakoja]

No description provided.

[mcclure]

I tested this patch against regressions caused by 3159:

• "Glitchy animation" during pulldown refresh— fixed (but I have animations disabled, would be good if someone could test on a second phone)
• Pulldown refresh fetches twice— Did not test, I don't know how to test this
• "when [pulldown] refreshing while offline fullscreen error appears so one can't see read already loaded notifications anymore"— fixed (I could not reproduce)
• Refreshing notifications collapses already expanded content warning #3623 - Refreshing notifications collapses already expanded content warning — fixed
• Notifications scroll can get stuck in the distant past (say by days) and you can't jump up to "the present" except by using the menu / "Load More" should come back until we make an explicit decision to remove this — I don't know how to test this because it would require leaving the app open for a long period. However in all my tests, closing and reopening the app caused the notifications tab to always jump to "the present", which mostly obviates this problem. I don't know if that's "expected"/as-of-March behavior.

[connyduck]

It's missing the button functions (needs Kotlin to call the Api)

add some more "old" functions to MastodonApi?

Most menu items are not wired (they were added after this code)

don't we want to get rid of them as well and have the old bar back?

There are some new functions with "Old" in the name which should be removed when Kotlin

That is fine

Some (newer) code can still be removed as it is now unused

remove it as well please

[mcclure]

don't we want to get rid of them as well and have the old bar back?

There are 4 items in the menu

• Refresh
• Load newest notifications
• Filter notifications
• Delete notifications

I think when we bring the bar back we should remove "Filter notifications" and "Delete notifications". (Except when the bar is hidden, which I think you said we had a preference for.)

But it may be worth keeping the menu for "Refresh" and "Load newest notifications". You can already get these both things with gestures (pull down or tap tab header) but having a second option when that is not clear might be good.

[connyduck]

I think when we bring the bar back we should remove "Filter notifications" and "Delete notifications". (Except when the bar is hidden, which I think you said we had a preference for.)

Yes makes sense.

"Load newest notifications" - was that a workaround to jump back to the top when one is way behind on notifications? If yes it makes no sense anymore, if no what is the difference to "refresh"?

[Lakoja]

Noticed something related in this code: #3648

Not sure if this is a problem (i. e. will fetch notifications endlessly as there are so many...).

Worth an investigation / followup?

[Lakoja]

It's missing the button functions (needs Kotlin to call the Api)

add some more "old" functions to MastodonApi?

Some (newer) code can still be removed as it is now unused

remove it as well please

Done 2x