On android 6.0, filter 0x00ad (unicode soft hyphen) from statuses #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connyduck
reviewed
Oct 12, 2018
| return (Spanned) ReplaceCrashingCharacters((CharSequence) content); | ||
| } | ||
|
|
||
| static CharSequence ReplaceCrashingCharacters(CharSequence content) { |
There was a problem hiding this comment.
methods should start with lowercase character
| Boolean replacing = false; | ||
| SpannableStringBuilder builder = null; | ||
|
|
||
| for (int index = 0; index < content.length(); ++index) { |
There was a problem hiding this comment.
its not guaranteed that length() is a simple getter, moving it out of the loop should be faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around #563
Tested with known offenders
The implementation isn't too elegant in reading-the-code terms, but I was pretty conscious about every status going through this codepath, so I tried to keep iteration and allocation to an absolute minimum.