Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post containing only U+00AD SOFT HYPHEN crashes tusky #563

Closed
1 task done
chr-1x opened this issue Apr 8, 2018 · 19 comments
Closed
1 task done

Post containing only U+00AD SOFT HYPHEN crashes tusky #563

chr-1x opened this issue Apr 8, 2018 · 19 comments
Labels

Comments

@chr-1x
Copy link

chr-1x commented Apr 8, 2018

after making this post i received a few reports that people trying to scroll past it were getting tusky crashes. i don't have details but the reports are visible in my replies: https://cybre.space/@chr/99821978136424081


  • Tusky Version: unknown, probably most recent as of this issue filing

  • Android Version: unknown

  • Android Device: unknown

  • Mastodon instance (if applicable): cybre.space

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.

@Zatnosk
Copy link

Zatnosk commented Apr 8, 2018

I left one of those reports.

It happens in Tusky 1.5.2 on Android 6.0.1 on my FairPhone 2

@Zatnosk
Copy link

Zatnosk commented Apr 8, 2018

And to answer a question in the mastodon thread, I installed from Play Store.

@Zatnosk
Copy link

Zatnosk commented Apr 8, 2018

No, wait, I thought I did, but F-Droid has it in it's list of installed apps on my phone. Sorry for multiposting :P

@remi6397
Copy link
Contributor

remi6397 commented Apr 8, 2018

@Zatnosk F-droid lists also programs installed from other sources. If Play has Tusky listed on My Apps, it is probably downloaded from Play.

@ciphercharly
Copy link

can confirm the issue, happening for me with Tusky 1.5.2 installed from F-droid on device running Android 6.0.1

@connyduck
Copy link
Collaborator

I cannot reproduce this issue on any of my 3 devices and I cant find a related stacktrace in the Google Play console unfortunately. Can somebody help me out, I would really like to fix this.

@ciphercharly
Copy link

@connyduck no issues at all with the f-droid version on all 3?

@connyduck
Copy link
Collaborator

@connyduck no issues at all with the f-droid version on all 3?

yes I just tested it

@ciphercharly
Copy link

weird... what extra info could I provide to help you?

@connyduck
Copy link
Collaborator

I would need a stacktrace. Do you know how to read the log of your device?

@ciphercharly
Copy link

ciphercharly commented Apr 9, 2018

never done for an app, I can try if guided. the device on which I am running Android is not rooted though.

@ciphercharly
Copy link

ciphercharly commented Apr 9, 2018

@connyduck done 'official' reporting after crashing, log should be attached (hated going through Google though), hope it helps, do you have access to such reports?

@connyduck
Copy link
Collaborator

Oh yes thank you now I see the crash log :)
Its the same problem as reported for SubwayTooter tateisu/SubwayTooter#69

@ciphercharly
Copy link

👍
out of curiosity, how does the log look like? could you paste a bit here?

@connyduck
Copy link
Collaborator

It seems to be a bug in the Android framework and not in Tusky

java.lang.IndexOutOfBoundsException: 
  at android.text.PackedIntVector.getValue (PackedIntVector.java:71)
  at android.text.DynamicLayout.getLineTop (DynamicLayout.java:619)
  at android.text.Layout.getLineBaseline (Layout.java:1257)
  at android.widget.TextView.getBaseline (TextView.java:5829)
  at android.widget.RelativeLayout.onMeasure (RelativeLayout.java:479)
  at android.view.View.measure (View.java:18850)
  at android.support.v7.widget.RecyclerView$LayoutManager.measureChildWithMargins (RecyclerView.java:8791)
  at android.support.v7.widget.LinearLayoutManager.layoutChunk (LinearLayoutManager.java:1584)
  at android.support.v7.widget.LinearLayoutManager.fill (LinearLayoutManager.java:1518)
  at android.support.v7.widget.LinearLayoutManager.onLayoutChildren (LinearLayoutManager.java:610)
  at android.support.v7.widget.RecyclerView.dispatchLayoutStep2 (RecyclerView.java:3719)
  at android.support.v7.widget.RecyclerView.dispatchLayout (RecyclerView.java:3436)
  at android.support.v7.widget.RecyclerView.onLayout (RecyclerView.java:3988)
  at android.view.View.layout (View.java:16692)
  at android.view.ViewGroup.layout (ViewGroup.java:5449)
  at android.support.v4.widget.SwipeRefreshLayout.onLayout (SwipeRefreshLayout.java:611)
  at android.view.View.layout (View.java:16692)
  at android.view.ViewGroup.layout (ViewGroup.java:5449)
  at android.support.v4.view.ViewPager.onLayout (ViewPager.java:1769)
  at android.view.View.layout (View.java:16692)
  at android.view.ViewGroup.layout (ViewGroup.java:5449)
  at android.widget.RelativeLayout.onLayout (RelativeLayout.java:1080)
  at android.view.View.layout (View.java:16692)
  at android.view.ViewGroup.layout (ViewGroup.java:5449)
  at android.support.design.widget.CoordinatorLayout.layoutChild (CoordinatorLayout.java:1171)
  at android.support.design.widget.CoordinatorLayout.onLayoutChild (CoordinatorLayout.java:856)
  at android.support.design.widget.CoordinatorLayout.onLayout (CoordinatorLayout.java:875)
  at android.view.View.layout (View.java:16692)
  at android.view.ViewGroup.layout (ViewGroup.java:5449)
  at android.support.v4.widget.DrawerLayout.onLayout (DrawerLayout.java:1172)
  at android.view.View.layout (View.java:16692)
  at android.view.ViewGroup.layout (ViewGroup.java:5449)
  at android.widget.FrameLayout.layoutChildren (FrameLayout.java:336)
  at android.widget.FrameLayout.onLayout (FrameLayout.java:273)
  at android.view.View.layout (View.java:16692)
  at android.view.ViewGroup.layout (ViewGroup.java:5449)
  at android.widget.LinearLayout.setChildFrame (LinearLayout.java:1743)
  at android.widget.LinearLayout.layoutVertical (LinearLayout.java:1586)
  at android.widget.LinearLayout.onLayout (LinearLayout.java:1495)
  at android.view.View.layout (View.java:16692)
  at android.view.ViewGroup.layout (ViewGroup.java:5449)
  at android.widget.FrameLayout.layoutChildren (FrameLayout.java:336)
  at android.widget.FrameLayout.onLayout (FrameLayout.java:273)
  at android.view.View.layout (View.java:16692)
  at android.view.ViewGroup.layout (ViewGroup.java:5449)
  at android.widget.LinearLayout.setChildFrame (LinearLayout.java:1743)
  at android.widget.LinearLayout.layoutVertical (LinearLayout.java:1586)
  at android.widget.LinearLayout.onLayout (LinearLayout.java:1495)
  at android.view.View.layout (View.java:16692)
  at android.view.ViewGroup.layout (ViewGroup.java:5449)
  at android.widget.FrameLayout.layoutChildren (FrameLayout.java:336)
  at android.widget.FrameLayout.onLayout (FrameLayout.java:273)
  at com.android.internal.policy.PhoneWindow$DecorView.onLayout (PhoneWindow.java:2707)
  at android.view.View.layout (View.java:16692)
  at android.view.ViewGroup.layout (ViewGroup.java:5449)
  at android.view.ViewRootImpl.performLayout (ViewRootImpl.java:2178)
  at android.view.ViewRootImpl.performTraversals (ViewRootImpl.java:1938)
  at android.view.ViewRootImpl.doTraversal (ViewRootImpl.java:1114)
  at android.view.ViewRootImpl$TraversalRunnable.run (ViewRootImpl.java:6068)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:858)
  at android.view.Choreographer.doCallbacks (Choreographer.java:670)
  at android.view.Choreographer.doFrame (Choreographer.java:606)
  at android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:844)
  at android.os.Handler.handleCallback (Handler.java:739)
  at android.os.Handler.dispatchMessage (Handler.java:95)
  at android.os.Looper.loop (Looper.java:152)
  at android.app.ActivityThread.main (ActivityThread.java:5497)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:726)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:616)

@ciphercharly
Copy link

yeah, and I do not get all the technical details but for what I understand one can only get a workaround..
it's not that serious luckily though

@charlag charlag added the bug label Apr 25, 2018
@charlag
Copy link
Collaborator

charlag commented May 5, 2018

I think we can replace this character to mitigate the issue?

@charlag charlag added the easy label May 5, 2018
@ashkitten
Copy link

What Android versions are affected, and can we gate this workaround to only apply to those versions?

@charlag
Copy link
Collaborator

charlag commented May 6, 2018

From what I can find it's Android 6
https://trello.com/c/hyks0exG/268-soft-hyphen-alt-0173-crashes-all-android-60-devices

We can apply it only for them. Would you like to try that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants