Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix link's too large hitbox #916

Merged
merged 4 commits into from Nov 12, 2018
Merged

fix link's too large hitbox #916

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6dae07
fix link's too large hitbox (tuskyapp#846)
kyori19 Nov 11, 2018
938d29b
Use zero width space instead of normal space.
kyori19 Nov 12, 2018
4d038b9
Add comment.
kyori19 Nov 12, 2018
3fe9f58
Remove unnecessary Html.fromHtml
kyori19 Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/src/main/java/com/keylesspalace/tusky/util/LinkHelper.java
View file
Open in desktop
Expand Up @@ -113,6 +113,18 @@ public void onClick(View widget) {
}
builder.removeSpan(span);
builder.setSpan(customSpan, start, end, flags);

/* Add zero-width space after links in end of line to fix its too large hitbox.
* See also : https://github.com/tuskyapp/Tusky/issues/846
* https://github.com/tuskyapp/Tusky/pull/916 */
if(end >= builder.length()){
builder.insert(end, "\u200B");
} else {
if(builder.subSequence(end, end + 1).toString().equals("\n")){
builder.insert(end, "\u200B");
}
}

}
view.setText(builder);
view.setLinksClickable(true);
Expand Down