Between direct delivery and retrieval from database

[adonese]

i think we should generate an id for the message whenever we construct a message. That will allow us to then identify the message and set its is_delivered status to true upon sending a message

[mseltahir]

Great, should we use UUID or do you have something else in mind?

[mseltahir]

Also, do you think the id generation should happen after we receive the message from the ws connection or that we should receive it with the message i.e. the android client generates the message ID?

[adonese]

I was thinking about uuid

[adonese]

i don't like them to be generated in the client, but at the same time, i really would love if we have would do as little as possible in the server. the ws in itself is demanding enough

[mseltahir]

If we are to use uuid, we should change the message ID type from int to string.

[mseltahir]

i don't like them to be generated in the client, but at the same time, i really would love if we have would do as little as possible in the server. the ws in itself is demanding enough

I too would prefer if it was on our side, I don't think it would take more than a few lines and we have the benefit of checking for the rather very unlikely case of key collision.

[adonese]

ok i will leave this for you

[mseltahir]

On it.

[mseltahir]

This was resolved in PR #18