Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom loading icon does not hide when updating toast type #21

Closed
1 of 2 tasks
charlieandroid55 opened this issue Jun 12, 2024 · 1 comment · Fixed by #22
Closed
1 of 2 tasks

Custom loading icon does not hide when updating toast type #21

charlieandroid55 opened this issue Jun 12, 2024 · 1 comment · Fixed by #22
Labels
bug Something isn't working released

Comments

@charlieandroid55
Copy link

Please provide the environment you discovered this bug in.

 <ngx-sonner-toaster
   <hlm-icon
          loading-icon
          name="lucideLoader2"
          class="animate animate-spin" />
  </ngx-sonner-toaster>

Description

I am currently using SpartanUi and when I add a custom icon for the loading toast, if I update the loading toast to any other state (success, error, etc.), the loading icon remains visible, even when using toast.promise().

Screenshot 2024-06-12 112433

Please provide the exception or error you saw

No response

Other information

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@charlieandroid55 charlieandroid55 added the bug Something isn't working label Jun 12, 2024
@tutkli
Copy link
Owner

tutkli commented Jun 13, 2024

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants