Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in "Click here to finish the game" button #7

Closed
arun1128 opened this issue Feb 13, 2016 · 6 comments
Closed

Bug in "Click here to finish the game" button #7

arun1128 opened this issue Feb 13, 2016 · 6 comments

Comments

@arun1128
Copy link
Collaborator

When this button is clicked multiple times, "Game over" image also appears multiple times with it's active event listener. And we're unable to play the game further

@Vigneshsekar
Copy link
Member

Thanks Arun. We'll fix the bug very soon. @karthikeyan5 has already started working on this issue.

@karthikeyan5
Copy link
Contributor

You have a good eye for Bugs @arun1128.
I have been working on this issue in the weekend and managed to fix it.
Please try it out and give your feedback (hopefully @Vigneshsekar accepts the pull request by then).
Thanks @arun1128

@Vigneshsekar
Copy link
Member

Thanks both of you. I am closing the issue.

@Vigneshsekar
Copy link
Member

If the player looses all three lives, "Click here to finish the game" button must disappear and "Game Over " button must appear.
In the latest pull request by @karthikeyan5, this was not made. So I will keep this issue open and will try to fix it soon.

karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by @Vigneshsekar.
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by @Vigneshsekar.
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by @Vigneshsekar.
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by @Vigneshsekar.
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by "Vigneshsekar".
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by "Vigneshsekar".
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by "Vigneshsekar".
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by "Vigneshsekar".
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by "Vigneshsekar".
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by "Vigneshsekar".
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by "Vigneshsekar".
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by "Vigneshsekar".
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 15, 2016
The issue #7 was reopened by "Vigneshsekar".
Necessary changes have been made and the issue has now been resolved again.
karthikeyan5 referenced this issue in karthikeyan5/Tux4ME Feb 16, 2016
Vigneshsekar added a commit that referenced this issue Feb 16, 2016
@karthikeyan5
Copy link
Contributor

@Vigneshsekar I hope the issue has been fixed.
if so, it would be a wonderful idea to close this issue. :)

@Vigneshsekar
Copy link
Member

Thanks karthikeyan5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants