Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AndroidHttpClient with OkHttpClient #78

Closed
wants to merge 4 commits into from
Closed

Replace AndroidHttpClient with OkHttpClient #78

wants to merge 4 commits into from

Conversation

cketti
Copy link
Contributor

@cketti cketti commented Dec 30, 2014

OkHttp has many nice features built-in and a nicer API. Check the OkHttp website for more details.

@cketti
Copy link
Contributor Author

cketti commented Dec 30, 2014

This also fixes issue #75.

@johnjohndoe
Copy link
Contributor

@cketti I reviewed your changes and they look good to me. I am happy to merge and test them for a redeployment of this app which I will release in a few days. Can you therefore please address the following issues to enable a clean merge:

  • Rebase onto current master of tuxmobil/CampFahrplan.
  • Update OkHttp to the latest version in commit b3f2c29.
  • Apply your build script changes of commit 8f546f1 to the camp2015 flavor as well.

Feel free to rewrite the history of your branch to produce clean commits!

@cketti
Copy link
Contributor Author

cketti commented Oct 12, 2015

Will do.

@johnjohndoe
Copy link
Contributor

@cketti I would need it within the next 24 hours to include it. Just let me know if you have time.

@cketti
Copy link
Contributor Author

cketti commented Oct 13, 2015

Sorry, it's unlikely I'll find the time to do it before the weekend.

@johnjohndoe
Copy link
Contributor

@cketti Would be very helpful if you can update/rebase this onto master before 11/16/15.

@johnjohndoe
Copy link
Contributor

@tuxmobil I updated (latest version of OkHttp, updated configuration for camp2015 flavor) and rebased this branch onto current master: https://github.com/johnjohndoe/CampFahrplan/tree/okhttp

@tuxmobil
Copy link
Owner

Thanks. Github shows merge conflicts, though.

@tuxmobil
Copy link
Owner

done, thanks.

@tuxmobil tuxmobil closed this Nov 24, 2015
@johnjohndoe
Copy link
Contributor

Merged here.

zoff99 pushed a commit to zoff99/CampFahrplan that referenced this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants