Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout cleanup #99

Closed
wants to merge 19 commits into from
Closed

Conversation

johnjohndoe
Copy link
Contributor

In this branch I cleaned up the layout resource files. The major aim was to remove duplicate definitions of views, attributes, values or even files to simplify the layout resources and to facilitate maintenance and customization.

  • I created styles from given attributes for the event detail layout.
  • Further, I used design time layout attributes to allow previewing layouts much more convenient.
  • Besides content preview attributes I used background and text colors to render views and their dimension in the preview panel of Android Studio. These colors are only used in the preview but not are applied in the final application.
  • Moreover, I added (different) placeholder texts for the English and German configuration.
  • I extracted colors, font sizes, margins.

The following screenshot shows a fragment of the event detail layout preview:

Event detail layout preview


Please let me know when you want to merge this branch. If you merged other work in the meantime I am happy to rebase this branch onto master to guarantee a clean, empty merge commit!

@tuxmobil
Copy link
Owner

Would you mind rebasing this branch?

@johnjohndoe
Copy link
Contributor Author

I will rebase it.

…ayout.

+ Here, `event_detail_text` implicitly applies to layout and layout-port.
+ The speakers style applies `android:typeface="normal"` to all layouts.
  Before, this attribute was not set on some layouts.
…tes.

+ Add background and text colors, show hidden views at design time.
@johnjohndoe
Copy link
Contributor Author

Merged here.

@johnjohndoe johnjohndoe deleted the layout-cleanup branch December 17, 2015 15:36
zoff99 pushed a commit to zoff99/CampFahrplan that referenced this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants