Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebridge Error while changing color of newly added lightstrip type 'dd' #75

Closed
kirit1193 opened this issue Jul 29, 2021 · 7 comments
Closed
Labels
bug Something isn't working released Resolved and released

Comments

@kirit1193
Copy link

Describe the bug
Homebridge Error while changing color of newly added lightstrip type 'dd'

Expected behavior
Color should change based on color selected in the HomeKit App.

Screenshots
If applicable, add screenshots to help explain your problem.

Logs
Adding: Smart LED Strip (dd / d76189faf2ce75243163ks)
Existing Accessory found Smart LED Strip d76189faf2ce75243163ks 7e87b51b-8ce0-4211-9a81-7de2040c403e

[29/7/2021, 7:40:19 am] [homebridge-tuya-platform] This plugin threw an error from the characteristic 'Hue': Unhandled error thrown inside write handler for characteristic: Cannot read property 'max' of undefined. See https://git.io/JtMGR for more info.
[29/7/2021, 7:42:08 am] [homebridge-tuya-platform] This plugin threw an error from the characteristic 'Hue': Unhandled error thrown inside write handler for characteristic: Cannot read property 'max' of undefined. See https://git.io/JtMGR for more info.

@kirit1193 kirit1193 added the bug Something isn't working label Jul 29, 2021
@github-actions
Copy link

Thank you for your feedback, we will solve this issue soon

@Hanh94
Copy link
Contributor

Hanh94 commented Jul 30, 2021

Hi @kirit1193 , Thank you for your feedback, We are aware of this issue and will fix it in the next release.

@Hanh94
Copy link
Contributor

Hanh94 commented Aug 5, 2021

Please update the plugin to version 1.3.1 and try again

@kirit1193
Copy link
Author

Hi @Hanh94, looks like the color control works now, however, the brightness control doesn't work or is missing.

Changing the color automatically sets the brightness to 49% and there is no way to change that from the HomeKit setup. If I set brightness from the Tuya app and change the color in HomeKit it auto-sets brightness back to 49%.

@Hanh94
Copy link
Contributor

Hanh94 commented Aug 6, 2021

Hi @kirit1193 , Do we know what's causing it and will we try to fix it in the next release.

@Hanh94 Hanh94 added to be released Resolved and will be released released Resolved and released and removed to be released Resolved and will be released labels Aug 10, 2021
@kirit1193
Copy link
Author

There doesn't seem to be a brightness parameter, just a Hue / Saturation / Value parameter being sent to the API:

TuyaOpenAPI request: method = post, endpoint = https://openapi.tuyain.com, path = /v1.0/devices/d76189faf2ce75243163ks/commands, params = null, body = {"commands":[{"code":"switch_led","value":true}]}, headers = {"t":"1629077775879","client_id":"redacted","nonce":"redacted","Signature-Headers":"client_id","sign":"redacted","sign_method":"HMAC-SHA256","access_token":"redacted","lang":"en","dev_lang":"javascript","dev_channel":"homebridge","devVersion":"1.3.1"} TuyaOpenAPI request: method = post, endpoint = https://openapi.tuyain.com, path = /v1.0/devices/redacted/commands, params = null, body = {"commands":[{"code":"colour_data","value":{"h":120,"s":1000,"v":475}}]}, headers = {"t":"1629077775879","client_id":"redacted","nonce":"redacted","Signature-Headers":"client_id","sign":"redacted","sign_method":"HMAC-SHA256","access_token":"redacted","lang":"en","dev_lang":"javascript","dev_channel":"homebridge","devVersion":"1.3.1"}

Perhaps if the brightness value is sent as well. This also explains why there is no brightness control for the 'dd' LED strip.

Does that help?

@kirit1193
Copy link
Author

Looks like this is closed in 1.4.0 with a brightness control. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Resolved and released
Projects
None yet
Development

No branches or pull requests

2 participants