Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract formatter #3

Merged
merged 7 commits into from Dec 23, 2013
Merged

Extract formatter #3

merged 7 commits into from Dec 23, 2013

Conversation

twada
Copy link
Member

@twada twada commented Dec 22, 2013

Trying to extract power-assert-formatter out.

empower module does not provide default formatter from now on.
power-assert module will compose assert object/function and formatter using empower function.

TODO

  • Delete power-assert-formatter related files
  • Change empower function signiture
  • Fake formatter for unit testing
  • Create power-assert-formatter module
  • Recover test coverage
  • Make formatter a function, not object
  • Do not provide bind for old browsers
  • Refactoring

empower module does not provide default formatter from now on.
power-assert module will compose assert object/function and formatter using empower function.
@ghost ghost assigned twada Dec 22, 2013
@coveralls
Copy link

Coverage Status

Coverage decreased (-11.84%) when pulling b6e1145 on extract_formatter into ee8dbce on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.73%) when pulling 21d1772 on extract_formatter into ee8dbce on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.37%) when pulling 82971d7 on extract_formatter into ee8dbce on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) when pulling b8af83d on extract_formatter into ee8dbce on master.

twada added a commit that referenced this pull request Dec 23, 2013
@twada twada merged commit d274e16 into master Dec 23, 2013
@twada twada deleted the extract_formatter branch December 23, 2013 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants