-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem installing 'main' files with bower #11296
Comments
Have escalated to the Bower folks. |
@cvrebert It looks like Bower doesn't support regexes in |
csomag elérhető NuGet . A reaktív Extensions (Rx) rajongók, mi is egy IObservable alapú " Octokit.Reactive "társa csomagot. |
When using bower the "main" property is used to specify the files that should be consumed by applications including the package as a dependency. Without including the fonts in this array the glyphicons do not work correctly as the relative font paths do not work after the "main" files are copied into my projects public dir using tools like https://github.com/yatskevich/grunt-bower-task For now I have manually copied the fonts dir in the location needed for my project. But by accepting this pull request this will not be necessary for me or for other people that use bower.
Urgh. Well my original PR listed out the individual files. But was asked to resubmit it like this. |
@thomaswelton Everyone gets many failures, this is one of them. Will you resubmit your origin pull request, or wait the Bower folks for fix? :) |
@zdroid @thomaswelton We'll fix it ourselves once we hear back from the Bower folks. |
I feel pretty bad. Like I totally broke the bower install of bootstrap by trying to make it better.
|
@thomaswelton Wait, why? I made million bad pull requests and commits, don't worry about this fail! :) |
@thomaswelton sorry, I thought this would work, but it doesn't, my bad! |
Okay, the Bower folks say that |
@cvrebert So, do it. |
Bower is nice, put it's also kinda awful... My original PR listed out the font files as individual declarations, which would have worked for the above setup. http://bower.io/#defining-a-package states that I thought the reason you were talking to the bower folks was to find out if the wildcard should have been supported. Not wether the CSS and font files should be removed. The css has been specified in that file since v2.2.0 https://github.com/twbs/bootstrap/blob/v2.2.0/component.json |
Can we fix the issue via #11599? |
Looks like the Bower folk are in reality still sorting out their spec/implementation. |
Merged #11599, which fixes the issue until such time as Bower ratifies a new spec and then implements it. |
@cvrebert thanks! |
Thanks for all the help guys, it's working great! |
I'm receiving the following message when using grunt-bower-task or bower-installer to grab the
main
files from the repository:The folder is there, and the build tools dont seem to recognize the wildcard. Is this a problem for anyone else, or is could it be a problem with my installation? Any info is appreciated.
My Gruntfile looks like so:
The commit that added the wildcard is here:
56f1ff6#diff-0a08a7565aba4405282251491979bb6b
The text was updated successfully, but these errors were encountered: