Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look if we need to add a fallback for word-break #28304

Closed
XhmikosR opened this issue Feb 19, 2019 · 6 comments
Closed

Look if we need to add a fallback for word-break #28304

XhmikosR opened this issue Feb 19, 2019 · 6 comments
Labels
css v4 v5

Comments

@XhmikosR
Copy link
Member

XhmikosR commented Feb 19, 2019 •
edited by Johann-S
Loading

Currently we are using word-break: break-word; in various places like code.

This isn't a standard property, at least not yet.

See if we need to provide a fallback.

/CC @mdo @MartijnCuppens
@XhmikosR XhmikosR added the css label Feb 19, 2019
@XhmikosR XhmikosR changed the title Look if we need to add a fallback in code for word-break Look if we need to add a fallback for word-break Feb 19, 2019
@bardiharborow
Copy link
Member

See #28381 for a possible solution.

@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 1, 2019

It's not a browser bug... this isn't a standard yet.

@bardiharborow
Copy link
Member

Browser support, is I guess what I meant. I don't know if we should have a label for that or not, but that's another issue.

@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 1, 2019 •
edited
Loading

We don't, thus how I actually noticed the issue. Using vnu.jar's web interface, which can also lint CSS, I saw the break-word errors and then looked into it.

IMO we shouldn't use non-standard properties when possible, and when we do we need to make sure we have fallbacks.

Because something works in Chrome/Chromium, certainly doesn't mean is standard, and we shouldn't endorse this.

@XhmikosR
Copy link
Member Author

/CC @twbs/css-review, not sure if this is still applicable.

@XhmikosR
Copy link
Member Author

/CC @twbs/css-review

@XhmikosR XhmikosR mentioned this issue Aug 29, 2019
Merged
@MartijnCuppens MartijnCuppens mentioned this issue Jan 23, 2020
Merged
@mdo mdo mentioned this issue May 13, 2020
Closed
@mdo mdo mentioned this issue May 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css v4 v5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XhmikosR @bardiharborow