Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5.2 Alert color is disabled #35569

Closed
cccabinet opened this issue Dec 18, 2021 · 1 comment · Fixed by #35571
Closed

v5.2 Alert color is disabled #35569

cccabinet opened this issue Dec 18, 2021 · 1 comment · Fixed by #35571
Labels
affects-main-branch css has-pr v5

Comments

@cccabinet
Copy link
Contributor

cccabinet commented Dec 18, 2021 •
edited by ffoodd
Loading

The alert setting was changed to a CSS variable in #35401, but the alert color is disabled.

ｖ5.1.3（https://getbootstrap.com/docs/5.1/components/alerts/#examples）
v5 1 3 Alerts

ｖ5.2.0（https://deploy-preview-35401--twbs-bootstrap.netlify.app/docs/5.1/components/alerts/#examples）
v5 2 0 Alerts

Please correct it.
@ffoodd
Copy link
Member

ffoodd commented Dec 18, 2021

You're right, there're at least two errors we didn't catch:

  • --bs-alert-color is weirdly set with padding values in the defaults,
  • color isn't set anymore.

We need to set color, and we may drop the default declaration since it's not needed.

@ffoodd ffoodd mentioned this issue Dec 20, 2021
Merged
@ffoodd ffoodd added the has-pr label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-main-branch css has-pr v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix alerts color twbs/bootstrap
3 participants
@XhmikosR @ffoodd @cccabinet