Carousel prev & next buttons busted in 2.2.0

[rvagg]

I believe that this fix is responsible for making the next and previous buttons on the carousel stop working, in fact, it simply leads to an extra setInterval() call so for each click you get another interval added.

The code previously had options = !$target.data('modal') && $.extend({}, $target.data(), $this.data()), the 'modal' typo meant that you always collected data from $target and $this; $this has the 'next' and 'prev' values on 'data-slide', so these actions never get passed up to $.fn.carousel where this line should be invoked: else if (action) data[action]() and instead falls through to else if (options.interval) data.cycle()

[grandfatha]

Can confirm this experience even with the carousel template website: http://twitter.github.com/bootstrap/examples/carousel.html

If you press the arrows, nothing happens, but after 10 seconds the images start to fly around like crazy.

[Anachron]

+1, I can confirm this.

[xmf]

Same here!

[DanielKulbe]

Yeah, big issue!

[mdo]

Yup, I've asked @fat to take a look and see what he can do. Sorry folks!

[derekrockwell]

+1

[boriskuzmanovic]

Confirmed bug.

[heldchen]

this bug is present since a few versions now, see #4938 for a jsfiddle that highlights the problem and a fix/workaround.

[sergiogarciadev]

I also confim the bug (Chrome 22, FF 16 e IE 10).

[29x10]

+1, big issue

[zonak]

I notified about this few days ago - thought it would be noticed:

edc3eee#commitcomment-2046579

So .. confirmed here too.

[rvagg]

👍 nice work @fat