Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Carousel prev & next buttons busted in 2.2.0 #5688

Closed
rvagg opened this Issue Oct 30, 2012 · 12 comments

Comments

Projects
None yet
Contributor

rvagg commented Oct 30, 2012

I believe that this fix is responsible for making the next and previous buttons on the carousel stop working, in fact, it simply leads to an extra setInterval() call so for each click you get another interval added.

The code previously had options = !$target.data('modal') && $.extend({}, $target.data(), $this.data()), the 'modal' typo meant that you always collected data from $target and $this; $this has the 'next' and 'prev' values on 'data-slide', so these actions never get passed up to $.fn.carousel where this line should be invoked: else if (action) data[action]() and instead falls through to else if (options.interval) data.cycle()

Can confirm this experience even with the carousel template website: http://twitter.github.com/bootstrap/examples/carousel.html

If you press the arrows, nothing happens, but after 10 seconds the images start to fly around like crazy.

+1, I can confirm this.

xmf commented Oct 30, 2012

Same here!

Yeah, big issue!

Owner

mdo commented Oct 30, 2012

Yup, I've asked @fat to take a look and see what he can do. Sorry folks!

Confirmed bug.

@itmustbe itmustbe referenced this issue in vwall/compass-twitter-bootstrap Oct 30, 2012

Closed

Update to Bootstrap 2.2 #77

this bug is present since a few versions now, see #4938 for a jsfiddle that highlights the problem and a fix/workaround.

I also confim the bug (Chrome 22, FF 16 e IE 10).

secjex commented Oct 31, 2012

+1, big issue

zonak commented Oct 31, 2012

I notified about this few days ago - thought it would be noticed:

edc3eee#commitcomment-2046579

So .. confirmed here too.

Contributor

rvagg commented Oct 31, 2012

👍 nice work @fat

@rvagg rvagg closed this Oct 31, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment